[cmd] Add missing C++ decorators #6599
Merged
+235
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starlight220
reviewed
May 8, 2024
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java
Show resolved
Hide resolved
wpilibNewCommands/src/test/java/edu/wpi/first/wpilibj2/command/CommandDecoratorTest.java
Show resolved
Hide resolved
Starlight220
approved these changes
May 24, 2024
|
|
||
| Command command = new WaitCommand(10).until(condition::get); | ||
| Command command = new RunCommand(() -> {}).until(finish::get); |
There was a problem hiding this comment.
All these instances of RunCommand(() -> {}) can be replaced with Commands.idle().
Not important enough to block this PR, though.
There was a problem hiding this comment.
I opened #6652 since there's a bunch of other spots in command tests that should also be updated. If this PR gets merged before the issue gets resolved, I'll update the list on the issue, and if the issue gets resolved first, then I'll update this PR.
Starlight220
changed the title
PeterJohnson
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
CommandPtrdidn't already haveAndThen,DeadlineFor,AlongWith, andRaceWithdecorators that take multiple commands, so I didn't add equivalents of those toCommand. (I did add the single command argument versions, though) This unfortunately affected theDeadlineFortest, so if people want me to add those as well in this PR then I'm fine with doing that. (Or if they want to do it themselves in a separate PR, that's cool too)Until,OnlyWhile,DeadlineFor,AlongWith,RaceWith, where the textual order of arguments matches the order of processing. (The decorated command is processed first (execute()run andisFinished()checked, optionally runningend()), then the arguments to the decorator)