Add command.repeatdly(int count) to both java and c++ #6589
+154
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also has unit tests in it!
In a single commit so it can be easily reverted when wanted
a diffrent pr This reverts commit 1bb8f4b.
Starlight220
reviewed
May 6, 2024
| * @return the decorated command | ||
| */ | ||
| public ParallelRaceGroup repeatedly(int times) { | ||
| int[] counter = {0}; |
There was a problem hiding this comment.
I'm familiar with this idiom, but we use AtomicInteger for by-ref integers everywhere else - so this should too.
spacey-sooty
reviewed
May 6, 2024
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandScheduler.cpp
Outdated
Show resolved
Hide resolved
wpilibNewCommands/src/main/native/cpp/frc2/command/CommandPtr.cpp
Outdated
Show resolved
Hide resolved
Comment on lines
212
to
216
| printf("Command %s is finished\n", command->GetName().c_str()); | ||
| m_impl->endingCommands.insert(command); | ||
| printf("Ending command %s\n", command->GetName().c_str()); | ||
| command->End(false); | ||
| printf("Command %s has ended\n", command->GetName().c_str()); |
There was a problem hiding this comment.
it is in the PR's message, that if you were to look at the unit tests, the C++ code doesn't function like the test expects it to do so. This is why I have added these print statements as a separate commit. They will be reverted before the merge
|
/format |
|
This was stated in Discord, but tests are probably failing because of an inconsistent order of when the commands in the internal deadline group are checked, which should be fixed by #6602. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the unit tests fail and there are a lot of print statements for whoever might be checking into this.
The problem is. The exact same function calls create different results between C++ and Java. I may just be the idiot but it seems to require further look into
The debug's are in different commits making it a lot easier to revert them if needed.