Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wpimath] Add more support for wpiunits in the geometry classes #6587

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[wpimath] Add more support for wpiunits in the geometry classes #6587

wants to merge 3 commits into from

Conversation

WispySparks
Copy link
Contributor

No description provided.

@WispySparks WispySparks requested a review from a team as a code owner May 6, 2024 00:23
spacey-sooty
spacey-sooty reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Rotation3d should also get support for Measures within this as otherwise Pose3d can't be created with all Measures

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacey-sooty spacey-sooty spacey-sooty approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WispySparks @spacey-sooty