Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElevatorExponentialProfile example #6605

Open
narmstro2020 opened this issue May 10, 2024 · 1 comment
Open

ElevatorExponentialProfile example #6605

narmstro2020 opened this issue May 10, 2024 · 1 comment

Comments

@narmstro2020
Copy link
Contributor

There seems to be an example not linked to the docs website in the code base. Exponential Elevator Profile and one for simulation as well.

When looking at the code there doesn't seem to be a correct Feedforward. SimpleMotorFeed forward is used instead.

Question #1: Is this correct or an oversight?

Question #2: Can ExponentialProfile be used with systems like Arms and Elevators as is or would they require modification to be more accurate as currently they take in kV and kA?

@calcmogul
Copy link
Member

calcmogul commented May 10, 2024

The examples need an overhaul in general. There's way too many to maintain, most of them are bad or outdated, and they're rarely used because teams don't know they exist.

We should replace all the elevator-adjacent examples with just one. Small "how do I use this feature" examples should probably be moved to the API docs, or frc-docs (the former is more likely to be kept up to date).

Either trapezoid or exponential profiles can be used, though they don't reflect the true dynamic limits. It works as long as the profile is conservative enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants