New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
be able to use InterpolatingDoubleTreeMap.put().put()... inline #6586
Comments
if this is decided to be done I have no prob implementing it. |
I think so long as you don't have to allocate a new object each time this is a fine feature to add |
no new allocation just return this |
An API shape like Java's existing InterpolatingDoubleTreeMap interpolationMap =
InterpolatingDoubleTreeMap.of(
2.90, 62,
2.52, 55,
2.25, 50,
3.59, 63,
3.04, 56
); |
I can see why some people would prefer a variadic double array but I can say for myself that I prefer chaining the .put() method for a clear separation between each pair. so how about adding both? |
I assume the put() call was modeled after the Java Map put() function, which returns the previous value, not the map itself. The current code returns void, but it might be confusing to return this when no other Map in Java does that (including TreeMap). https://docs.oracle.com/javase/8/docs/api/java/util/Map.html#put-K-V- Is there a reason you want to chain here? You can always put code into a static {} block. |
the reason is ease of use and readability. I prefer the lower example it makes it easier and faster to add multiple values one after the other and keeps a clear separation between the added values, unlike a variadic double array.
|
What if instead of |
We could implement this function from the standard library: I strongly suggest we don't deviate from stdlib conventions, because it's intended to act like a stdlib type. |
Is your feature request related to a problem? Please describe.
for me it is a bit annoying not being able to use .put when creating a new tree map and also not being able to use .put() in a constants class.
Describe the solution you'd like
solution: return the tree when using .put() so you can do as the example below and add all of the data inline.
public static final InterpolatingDoubleTreeMap INTERPOLATION_MAP = new InterpolatingDoubleTreeMap().put(2.9, 62.0).put(2.52 , 55.0).put(2.15 , 50.0).put(3.59, 63.0).put(3.04, 56.0);
The text was updated successfully, but these errors were encountered: