New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic pandoc export to pdf functionality #134
base: develop
Are you sure you want to change the base?
Conversation
I will have a look as soon as possible. |
@sipi this should be pretty safe. If nothing else it has no chance of hurting anything else, the only thing it's lacking is better reason-for-failure notifications if something doesn't work (such as not having latex / pandoc). |
Also lacking integration with settings, but I'll add that later when I have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tecosaur, here is some feedbacks about the code
Thanks for the review @AdrieanKhisbe! |
@tecosaur I converted to async await. Tell me what you think Seems we need to rebase on develop since branch is outdated. |
I tried to test it but I got this error:
Seems like having different authors prevents the usual disabling of the extension you are trying to test. I was able to get it working by disabling the After that, tested, it works! 😃 I'll probably add one or two minor commits in the next half hour, then if you wouldn't mind rebasing that would be good :) |
@tecosaur Rebasing would solve this. (I hadd to make the same edit, but I did not commit it) |
There we go, that just makes things a little bit nicer. Feel free to rebase :) |
Requested by @AdrieanKhisbe Co-Authored-By: tecosaur <20903656+tecosaur@users.noreply.github.com>
3733d5a
to
0ee7e5a
Compare
@tecosaur And here it is :) |
Do you recon it's good to go now? |
@tecosaur Ideally I prefer someone else review. Also I still should have a test to second command And test should ideally be green :/ |
Resolves #130