Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic pandoc export to pdf functionality #134

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tecosaur
Copy link

Resolves #130

@tecosaur
Copy link
Author

The new look:

image

@sipi
Copy link
Member

sipi commented Feb 13, 2019

I will have a look as soon as possible.

@tecosaur
Copy link
Author

tecosaur commented Mar 9, 2019

@sipi this should be pretty safe. If nothing else it has no chance of hurting anything else, the only thing it's lacking is better reason-for-failure notifications if something doesn't work (such as not having latex / pandoc).

@tecosaur tecosaur requested a review from sipi March 9, 2019 07:57
@tecosaur
Copy link
Author

Also lacking integration with settings, but I'll add that later when I have time.

@AdrieanKhisbe AdrieanKhisbe self-requested a review March 19, 2019 07:25
Copy link
Member

@AdrieanKhisbe AdrieanKhisbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tecosaur, here is some feedbacks about the code

src/pandoc-export.ts Outdated Show resolved Hide resolved
src/pandoc-export.ts Outdated Show resolved Hide resolved
src/pandoc-export.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
@tecosaur
Copy link
Author

tecosaur commented Mar 19, 2019

Thanks for the review @AdrieanKhisbe!

@AdrieanKhisbe
Copy link
Member

@tecosaur I converted to async await. Tell me what you think

Seems we need to rebase on develop since branch is outdated.
I can take care of it if you want :)

@AdrieanKhisbe AdrieanKhisbe self-requested a review March 19, 2019 20:50
@tecosaur
Copy link
Author

I tried to test it but I got this error:

Activating extension 'tootone.org-mode' failed:
command 'org.insertHeadingRespectContent' already exists.

Seems like having different authors prevents the usual disabling of the extension you are trying to test. I was able to get it working by disabling the vscode-org-mode.vscode-org-mode extension.

After that, tested, it works! 😃

I'll probably add one or two minor commits in the next half hour, then if you wouldn't mind rebasing that would be good :)

@AdrieanKhisbe
Copy link
Member

@tecosaur Rebasing would solve this. (I hadd to make the same edit, but I did not commit it)

@tecosaur
Copy link
Author

There we go, that just makes things a little bit nicer. Feel free to rebase :)

@AdrieanKhisbe
Copy link
Member

@tecosaur And here it is :)

@tecosaur
Copy link
Author

Do you recon it's good to go now?

@AdrieanKhisbe
Copy link
Member

@tecosaur Ideally I prefer someone else review.

Also I still should have a test to second command pandocEditTemplateCommand

And test should ideally be green :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants