Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(networks): add support for Base sepolia #13529

Merged
merged 19 commits into from Mar 29, 2024
Merged

feat(networks): add support for Base sepolia #13529

merged 19 commits into from Mar 29, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 27, 2024

Description

This adds support for Base Sepolia

Issues

Fixes #
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 March 27, 2024 13:58
@cla-bot cla-bot bot added the cla-signed label Mar 27, 2024
@clemsos
Copy link
Member Author

clemsos commented Mar 27, 2024

Creating a lock from unlock-app works locally but the UI crash (likely because it is trying to fetch data from staging)

@julien51
Copy link
Member

Creating a lock from unlock-app works locally but the UI crash (likely because it is trying to fetch data from staging)

Hum. Maybe from the subgraph?

We should try to get down to the bottom of what exactly fails?

julien51
julien51 reviewed Mar 27, 2024
View reviewed changes
packages/networks/src/networks/base-sepolia.ts Outdated
previousDeploys: [],

// provider: 'https://rpc.unlock-protocol.com/84532',
provider: 'https://sepolia.base.org',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll deploy that shortly!

julien51
julien51 requested changes Mar 27, 2024
View reviewed changes
Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run the health check script:

[Base Sepolia (84532)]: 0x68F2c5D9009dc4d553f814D689102a53B2b349Cc ❌ Policy below 2!
[Base Sepolia]: ⚠️  ProxyAdmin owner is not the team multisig
[Base Sepolia]: ⚠️  Unlock owner is not the team multisig

Please make sure you set it correctly so we don't have any issue later!!

@julien51
Copy link
Member

I would love to find a way to run these scripts as part of CI when adding new networks!

@julien51
Copy link
Member

Also I have deployed the provider :)

@clemsos
Copy link
Member Author

clemsos commented Mar 29, 2024

ok ownership of the contracts have been transferred

@julien51
Copy link
Member

Thx! Tested and LGTM

@julien51 julien51 merged commit cf05771 into master Mar 29, 2024
13 checks passed
blahkheart pushed a commit to blahkheart/unlock that referenced this pull request Mar 30, 2024
@clemsos @julien51 @blahkheart
feat(networks): add support for Base sepolia (unlock-protocol#13529)
fa63c3d 
* add basic network file

* readme typo

* add verification

* remove unused param

* unlock deploymeny

* etherscan api key

* update base scan api key again

* correct unlock address

* use actual proxy address

* add subgraph

* update readme

* add multisig

* add provider

* Update packages/networks/src/networks/base-sepolia.ts

* use unlock provider

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
julien51 added a commit that referenced this pull request Apr 4, 2024
@blahkheart @julien51
@renovate @SVell @ccarfi @clemsos @TylerSehr
Arbitrum L1 to L2 messaging proposal (#13516)
a5c3404 
* added 010-arbitrum-l1-l2-messaging.js to /goverance/proposals

* removed unnecessary comments

* moved ERC20_ABI and INBOX_ABI inline and removed /helper/abi folder

* signed Contributor License Agreement

* removed console logs, and .env file

* used fixed version numbers for arbitrum packages, added config.js file

* changed excessFeeRefundAddress to the dao's address

* added comments in front of params to provide their names

* formated proposal description correctly

* feat(locksmith): better fatal error handling with a logging statement

* feat(locksmith): adding cache for decoy users

* fix(deps): update dependency express [security] (#13524)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* fix(deps): update dependency unified to v11, remark-html to v15, remark-parse to v11 (#13531)

* Updated unified & related dependencies

* Updated remark

* Revert "fix(deps): update dependency unified to v11, remark-html to v15, remark-parse to v11" (#13532)

Revert "fix(deps): update dependency unified to v11, remark-html to v15, rema…"

This reverts commit 80969a6.

* feat(unlock-app): changed the UI for refunds per Dappcon Team requests (#13528)

* changed the UI for refunds per Gnosis

* refactored receipt number

* fix(unlock-protocol-com): removed distDir from next config

* Ccarfi microcopy fixes on referrals and refunds (#13536)

* Update Referrals.tsx

microcopy fix

* Update CancellationForm.tsx

microcopy update

* Update UpdateReferralFee.tsx

microcopy update

* feat(docs): add changelog for Unlock 13 and PublicLock 14 (#13534)

* add publicLock changelog

* add Unlock changelog

* add contributors to .clabot (#13537)

* feat(governance): allow test execution of proposal from tx id (#13509)

* allow test execution of proposal from tx id

* parse and pass correctly tx args

* add unlock addresses in whales

* allow proposal id only for votes

* pass odwn tx receipt

* herlpes for gov contract

* log events after proposal execution

* Update governance/scripts/gov/index.js

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>

* fix(deps): update dependency @nuintun/qrcode to v4 (#13541)

* Updated nuintun/qrcode

* Update qrcode.ts

* fix(deps): update dependency unified to v11, remark-html to v16, remark-parse to v11 (#13535)

* Updated unified & related dependencies

* Updated remark

* Fixed dependencies in unlock-app

* fix(locksmith) fixing export (#13542)

fixing export

* feat(networks): add support for Base sepolia (#13529)

* add basic network file

* readme typo

* add verification

* remove unused param

* unlock deploymeny

* etherscan api key

* update base scan api key again

* correct unlock address

* use actual proxy address

* add subgraph

* update readme

* add multisig

* add provider

* Update packages/networks/src/networks/base-sepolia.ts

* use unlock provider

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>

* cleanup: removed goerli (#13540)

* removed goerli

* removed stale include

* linting

* using op instead of goerli in tests

* fixing tests

* Updated PR to address comments
* Replaced arbLog with regular console log
* Removed changes in .env.copy
* Used fixed version numbers for arbitrum sdk packages
* Used env variables place holder for privateKey and API keys
* Move addresses to separate config file `config.js`
* Changed excessFeeRefundAddress to timelock address
* Added comments in front of function params to provide their names
* Formated Proposal description correctly

* Updated PR
* Downgraded to ethers 6.10.0
* Switched L2RPC to Unlock RPC for Arbitrum
* Moved createRetyrableTicket Params to variable for consistency
* Capitalize constant names

* Resolved yarn.lock merge conflict

* Updated PR:
* Used providers, and addresses from networks package
* Renamed config.js to constants.js
* Used suggested style guide for variable names
* More detailed description

* Update governance/proposals/constants.js

* Update governance/proposals/010-arbitrum-l1-l2-messaging.js

* use ethers5

* refactor proposal

* * Revert change to .gitignore, and .env.copy
* Use actual amount of ARB tokens required

* * Update proposal description
* Use correct proposal amount
* Revert .gitignore, and .env.copy changes

---------

Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Viacheslav <surzhenkoviacheslav@gmail.com>
Co-authored-by: Christopher Carfi <ccarfi@gmail.com>
Co-authored-by: Clément Renaud <clement@unlock-protocol.com>
Co-authored-by: Tyler Sehr <tysehr37@gmail.com>
Co-authored-by: Clément Renaud <clement.renaud@gmail.com>
Co-authored-by: Clément Renaud <clement+git@clementrenaud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien51 julien51 julien51 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clemsos @julien51