feat(governance): allow test execution of proposal from tx id #13509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien51
reviewed
Mar 26, 2024
julien51
approved these changes
Mar 26, 2024
6 tasks
blahkheart
pushed a commit
to blahkheart/unlock
that referenced
this pull request
Mar 30, 2024
…-protocol#13509) * allow test execution of proposal from tx id * parse and pass correctly tx args * add unlock addresses in whales * allow proposal id only for votes * pass odwn tx receipt * herlpes for gov contract * log events after proposal execution * Update governance/scripts/gov/index.js --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com>
julien51
added a commit
that referenced
this pull request
Apr 4, 2024
* added 010-arbitrum-l1-l2-messaging.js to /goverance/proposals * removed unnecessary comments * moved ERC20_ABI and INBOX_ABI inline and removed /helper/abi folder * signed Contributor License Agreement * removed console logs, and .env file * used fixed version numbers for arbitrum packages, added config.js file * changed excessFeeRefundAddress to the dao's address * added comments in front of params to provide their names * formated proposal description correctly * feat(locksmith): better fatal error handling with a logging statement * feat(locksmith): adding cache for decoy users * fix(deps): update dependency express [security] (#13524) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency unified to v11, remark-html to v15, remark-parse to v11 (#13531) * Updated unified & related dependencies * Updated remark * Revert "fix(deps): update dependency unified to v11, remark-html to v15, remark-parse to v11" (#13532) Revert "fix(deps): update dependency unified to v11, remark-html to v15, rema…" This reverts commit 80969a6. * feat(unlock-app): changed the UI for refunds per Dappcon Team requests (#13528) * changed the UI for refunds per Gnosis * refactored receipt number * fix(unlock-protocol-com): removed distDir from next config * Ccarfi microcopy fixes on referrals and refunds (#13536) * Update Referrals.tsx microcopy fix * Update CancellationForm.tsx microcopy update * Update UpdateReferralFee.tsx microcopy update * feat(docs): add changelog for Unlock 13 and PublicLock 14 (#13534) * add publicLock changelog * add Unlock changelog * add contributors to .clabot (#13537) * feat(governance): allow test execution of proposal from tx id (#13509) * allow test execution of proposal from tx id * parse and pass correctly tx args * add unlock addresses in whales * allow proposal id only for votes * pass odwn tx receipt * herlpes for gov contract * log events after proposal execution * Update governance/scripts/gov/index.js --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com> * fix(deps): update dependency @nuintun/qrcode to v4 (#13541) * Updated nuintun/qrcode * Update qrcode.ts * fix(deps): update dependency unified to v11, remark-html to v16, remark-parse to v11 (#13535) * Updated unified & related dependencies * Updated remark * Fixed dependencies in unlock-app * fix(locksmith) fixing export (#13542) fixing export * feat(networks): add support for Base sepolia (#13529) * add basic network file * readme typo * add verification * remove unused param * unlock deploymeny * etherscan api key * update base scan api key again * correct unlock address * use actual proxy address * add subgraph * update readme * add multisig * add provider * Update packages/networks/src/networks/base-sepolia.ts * use unlock provider --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com> * cleanup: removed goerli (#13540) * removed goerli * removed stale include * linting * using op instead of goerli in tests * fixing tests * Updated PR to address comments * Replaced arbLog with regular console log * Removed changes in .env.copy * Used fixed version numbers for arbitrum sdk packages * Used env variables place holder for privateKey and API keys * Move addresses to separate config file `config.js` * Changed excessFeeRefundAddress to timelock address * Added comments in front of function params to provide their names * Formated Proposal description correctly * Updated PR * Downgraded to ethers 6.10.0 * Switched L2RPC to Unlock RPC for Arbitrum * Moved createRetyrableTicket Params to variable for consistency * Capitalize constant names * Resolved yarn.lock merge conflict * Updated PR: * Used providers, and addresses from networks package * Renamed config.js to constants.js * Used suggested style guide for variable names * More detailed description * Update governance/proposals/constants.js * Update governance/proposals/010-arbitrum-l1-l2-messaging.js * use ethers5 * refactor proposal * * Revert change to .gitignore, and .env.copy * Use actual amount of ARB tokens required * * Update proposal description * Use correct proposal amount * Revert .gitignore, and .env.copy changes --------- Co-authored-by: Julien Genestoux <julien.genestoux@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Viacheslav <surzhenkoviacheslav@gmail.com> Co-authored-by: Christopher Carfi <ccarfi@gmail.com> Co-authored-by: Clément Renaud <clement@unlock-protocol.com> Co-authored-by: Tyler Sehr <tysehr37@gmail.com> Co-authored-by: Clément Renaud <clement.renaud@gmail.com> Co-authored-by: Clément Renaud <clement+git@clementrenaud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tx hash is required to fetch args submited with the proposal .
Usage:
Issues
Fixes #
Refs #13504
Checklist:
Release Note Draft Snippet