Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add aliases for latest versions of the contracts #13484

Merged
merged 11 commits into from Mar 20, 2024

Conversation

clemsos
Copy link
Member

@clemsos clemsos commented Mar 18, 2024

Description

This creates a consistent way to check the latest supported versions of Unlock and PublicLock by adding exports to our contracts package. That will prevent errors where various packages get out of sync across the monorepo

Issues

Fixes #9357
Refs #

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the docs to reflect my changes if applicable
  • I have added tests (and stories for frontend components) that prove my fix is effective or that my feature works
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

Release Note Draft Snippet

@clemsos clemsos requested a review from julien51 March 18, 2024 14:07
@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
UnlockSwapPurchaser,
UnlockSwapBurner,
UniswapOracleV3,
}
Copy link
Member Author

@clemsos clemsos Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing that file should fix the annoying build issue with git staged lint

Copy link
Member

@julien51 julien51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment on lines +19 to +20
PUBLICLOCK_LATEST_VERSION,
UNLOCK_LATEST_VERSION,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -1,5 +1,9 @@
# CHANGELOG

### 0.1.5

- Use version number directly fromn contracts packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Use version number directly fromn contracts packages
- Use version number directly from contracts packages

@clemsos clemsos merged commit 385a951 into master Mar 20, 2024
13 checks passed
@clemsos clemsos deleted the contracts-versions-alias branch March 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alias for Unlock in @unlock-protocol/contracts
2 participants