Add support for better highlighting. Addressing issue #15

[dkundel]

I didn't update the screenshots. I suggest you to clone my fork to actually test it out. Feedback is more than welcome 🙂

You can switch back to the previous style of highlighting by running tslide README.md --legacy.

[loklaan]

LGTM 👏

Played with it on gnome terminal and terminator. I hadn't noticed before, because I haven't given talks from a linux environment, but this has actually made tslides usable on those afore mentioned terminals. 😆 🎉

Will try it on iterm2 later.

[hackergrrl]

Nice work, @dkundel! I like the colours, and how code blocks get highlighted.

I did notice that lists are indented by 4 spaces horizontally and 1 vertically. This cuts down on available available space and causes many of my existing slides to wrap:

(top: new, bottom: legacy)

I've also seen some additional odd nestedlist behaviour:

[dkundel]

The indentation that you see is done by this line https://github.com/mikaelbr/marked-terminal/blob/master/index.js#L107 in their library. Unfortunately the part I can easily configure is the this.o.list() part but not the actual indentation, unless I overwrite the prototype.

[loklaan]

@dkundel marked-terminal@1.7.0 now supports a tab option to override the spacing. ;) Thanks for the advice above, it was easy to implement.

I forked it to tslide/marked-terminal, so if you need anything else fixed try and do it there, or let me know and I can do it.

Moving forward, I think this branch is nearly ready to be merged.

[loklaan]

@noffle Those attached images are 404'ing. As for what you mentioned... I've fixed the indentation issue (it is customisable). The vertical padding is going through a couple fixes/changes in mikaelbr/marked-terminal#27 - I wouldn't mind you weighing in here or there about what you'd prefer for tslides rendering.

[loklaan]

marked-terminal@2.0.0 is out, and is helping this PR look 👌.

I moved @dkundel's branch into tslide/tslide incorporated the new changes from marked-terminal, but I've now realised that the 'from' branch in a PR cannot be changed... So, in the absence of dkundel I'll just create a new PR later in the week, and organise a major version release (if no one objects).

[rafaelrinaldi]

@loklaan Need a hand with this? Got some free time next week 😃

[loklaan]

That'd be great @rafaelrinaldi - I dropped the ball on this one.

https://github.com/tslide/tslide/tree/marked-highlighting

[dominictarr]

these colors do not work for me (using the simplest terminal - xterm)
it either looks like this:

or like this

tslide really should work on the simplest terminal, including in the raw console you get before loading a window manager. I think the main problem is that the default text is coloured, but I think the main text should be the default colour, and apply styles to the keywords.

[dominictarr]

helpful context: I used to use light-on-dark, because it looks nice, but I switched to dark-on-light because it's more readable in daylight.

[dominictarr]

oh, looks like need to make a PR to cardinal for a more reasonable theme.