Be able to use own encoder and decoder. #1080
Conversation
| let encoder: JSONEncoder | ||
| let decoder: JSONDecoder | ||
|
|
||
| public init(decoder: JSONDecoder = .init(), encoder: JSONEncoder = .init()) { |
There was a problem hiding this comment.
Why you decided to create an initializer for these properties?
I think this development is unnecessary to use encoder and decoder because these properties aren't use anywhere except functions.
On the other hand some cases we don't need to create encoder or decoder.
For example; if data comes NULL in transformFromJSON (_ value:) -> Object? function returns immediately from guard statement and we don't create a decoder.
transformToJSON (_ value: ) -> JSON? has a same case, if value comes NULL we don't create encoder.
What do you think about this cases?
There was a problem hiding this comment.
We want to set options for JSONDecoder and JSONEncoder.
For example, cannot set dataDecodingStrategy by current code.
Sources/CodableTransform.swift
Outdated
|
|
||
| public init() {} | ||
| let encoder: JSONEncoder | ||
| let decoder: JSONDecoder |
There was a problem hiding this comment.
Maybe you should consider making those properties private. What do you think?
There was a problem hiding this comment.
YES, serializers should be private.
No description provided.