Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TINY-10878: Fix issue with emojis not loading due to broken CDN link #9611

Closed
wants to merge 2 commits into from
Closed

TINY-10878: Fix issue with emojis not loading due to broken CDN link #9611

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0874a39
TINY-10878: Fix issue with emojis not loading due to broken CDN link
ArvinJ-H May 2, 2024
0491b31
Update modules/tinymce/src/plugins/emoticons/main/ts/api/Options.ts
ArvinJ-H May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/tinymce-TINY-10878-2024-05-02.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
project: tinymce
kind: Fixed
body: Resolved an issue where emojis were not loading correctly due to a broken CDN
link.
time: 2024-05-02T19:19:00.487471+10:00
custom:
Issue: TINY-10878
2 changes: 1 addition & 1 deletion modules/tinymce/src/plugins/emoticons/main/ts/api/Options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const register = (editor: Editor, pluginUrl: string): void => {

registerOption('emoticons_images_url', {
processor: 'string',
default: 'https://twemoji.maxcdn.com/v/13.0.1/72x72/'
default: 'https://cdnjs.cloudflare.com/ajax/libs/twemoji/15.1.0/72x72/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that our product works like this. I mean this isn't really on-prem if you enable this it goes out on the internet for things.

Copy link
Member

@TheSpyder TheSpyder May 8, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is documented, though. Including how to make it properly on-prem.
https://www.tiny.cloud/docs/tinymce/latest/emoticons/#emoticons_images_url

Speaking of which, we should change the docs URL for downloading the image assets to the new maintenance home as well... @ArvinJ-H can you please log a JIRA ticket for that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right I think this is the only thing that works like this that depends on a third party url. It's just a bit odd. I see why we do it we don't want to download that huge thing and ship that. But I guess most people just use the unicode emojis.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speaking of which, we should change the docs URL for downloading the image assets to the new maintenance home as well... @ArvinJ-H can you please log a JIRA ticket for that

@ArvinJ-H Could you please create a documentation ticket if it hasn't been done yet?

Copy link
Contributor Author

@ArvinJ-H ArvinJ-H May 13, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there was a ticket logged to update the url in doc, forgot to link it in ticket.

https://ephocks.atlassian.net/browse/DOC-2406

Also closing this pr and created a new hotfix branch to merge into release/7, targeting 7.1.1

});
};

Expand Down