TINY-10878: Fix issue with emojis not loading due to broken CDN link #9611
Conversation
ArvinJ-H
requested review from
a team,
ltrouton,
MitchC1999,
Skylite73 and
danoaky-tiny
and removed request for
a team
Co-authored-by: Andrew Herron <thespyder@programmer.net>
| @@ -40,7 +40,7 @@ const register = (editor: Editor, pluginUrl: string): void => { | |||
|
|
|||
| registerOption('emoticons_images_url', { | |||
| processor: 'string', | |||
| default: 'https://twemoji.maxcdn.com/v/13.0.1/72x72/' | |||
| default: 'https://cdnjs.cloudflare.com/ajax/libs/twemoji/15.1.0/72x72/' | |||
There was a problem hiding this comment.
I'm surprised that our product works like this. I mean this isn't really on-prem if you enable this it goes out on the internet for things.
There was a problem hiding this comment.
It is documented, though. Including how to make it properly on-prem.
https://www.tiny.cloud/docs/tinymce/latest/emoticons/#emoticons_images_url
Speaking of which, we should change the docs URL for downloading the image assets to the new maintenance home as well... @ArvinJ-H can you please log a JIRA ticket for that
There was a problem hiding this comment.
Right I think this is the only thing that works like this that depends on a third party url. It's just a bit odd. I see why we do it we don't want to download that huge thing and ship that. But I guess most people just use the unicode emojis.
There was a problem hiding this comment.
yes, there was a ticket logged to update the url in doc, forgot to link it in ticket.
https://ephocks.atlassian.net/browse/DOC-2406
Also closing this pr and created a new hotfix branch to merge into release/7, targeting 7.1.1
Related Ticket:
TINY-10878
Description of Changes:
Pre-checks:
Tests have been added (if applicable)feature/,hotfix/orspike/Review:
GitHub issues (if applicable):