Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated token for pr assignment #6868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

svenklemm
Copy link
Member

Since changing the default permissions of the GITHUB_TOKEN this workflow was failing with insufficient permissions.

@svenklemm svenklemm force-pushed the assigned_pr branch 3 times, most recently from 97a6a56 to 94fea3a Compare April 28, 2024 06:56
Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.93%. Comparing base (59f50f2) to head (282bb3f).
Report is 136 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6868      +/-   ##
==========================================
+ Coverage   80.06%   80.93%   +0.86%     
==========================================
  Files         190      198       +8     
  Lines       37181    37291     +110     
  Branches     9450     9738     +288     
==========================================
+ Hits        29770    30181     +411     
- Misses       2997     3202     +205     
+ Partials     4414     3908     -506     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Since changing the default permissions of the GITHUB_TOKEN this
workflow was failing with insufficient permissions.
Copy link
Contributor

@mkindahl mkindahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have a reference to the changes in permissions for GITHUB_TOKEN? Could you please add them to the PR?

Comment on lines 18 to +24
assign-pr:
name: Assign PR to author
permissions:
contents: write
runs-on: ubuntu-latest
steps:
- uses: toshimaru/auto-author-assign@v2.1.0
with:
repo-token: ${{ secrets.ORG_AUTOMATION_TOKEN }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now this job will execute also when the PR is labeled and unlabeled as well as edited and synchronized. Don't we need to have checks to avoid running this unnecessarily?

@svenklemm svenklemm self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants