New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluespace pipes #30863
Bluespace pipes #30863
Conversation
Love it. |
Would it be possible to connect atmospherics in lavaland with the station's atmospherics? |
This'll take atmos sabotage potential to a new level. |
user.visible_message("<span class='notice'>[user] paints \the [P] [mode].</span>","<span class='notice'>You paint \the [P] [mode].</span>") | ||
P.update_node_icon() //updates the neighbors | ||
if(P.paint(GLOB.pipe_paint_colors[paint_color])) | ||
playsound(get_turf(src), 'sound/machines/click.ogg', 50, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
playsound(src
|
||
/obj/item/device/pipe_painter/examine() | ||
..() | ||
to_chat(usr, "It is set to [mode].") | ||
to_chat(usr, "It is set to [paint_color].") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
examine(mob/user) and to_chat(user,...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also add a notice span
return 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TRUE
/obj/machinery/atmospherics/pipe/bluespace/New() | ||
icon_state = "pipe" | ||
GLOB.bluespace_pipes += src | ||
..() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initialize and . = ..() first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll open another PR in a few minutes/hours to change all atmos machines to use initialize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too many pipenet related things broke during mapload when I tried changing to Initialize
so I'm just gonna leave it for now if that's ok with you.
qdel(P.parent) | ||
P.parent = null | ||
. = ..() | ||
for(var/p in GLOB.bluespace_pipes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return ..() last
Should be twinned pipes or use a channel, if it's global you can only have one single autism project with these |
yeah, giving it a frequency or channel system would be a massive improvement. |
If you don't go with channels, make sure to take these out of the rpd's build list. Any shmuck who has time can print an rpd out of a hacked lathe and then fuck up your autism project by volume pumping the gas into space |
Allow RPD to hold bluespace crystals, make those buildable with bluespace crystal charges? |
imo they shouldn't be free (and in my very honest opinion they shouldn't be common either but whatever) |
GLOB.bluespace_pipes -= src | ||
for(var/p in GLOB.bluespace_pipes) | ||
var/obj/machinery/atmospherics/pipe/bluespace/P = p | ||
qdel(P.parent) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QDEL_NULL(P.parent)
and remove next line
If they could be paired with a multitool on a specific frequency each, for example, then they'd offer great tools for future mappers who aren't concerned about making their creations' atmos networks too physical and complex. |
I can think of so many great uses for this. This might make me an Atmos player again. 😍 |
imo these should be VERY expensive since i expect people to highly cheat atmos with these. |
I think these would be best off being gated behind R&D or cargo or something as opposed to unlimited supply from the RPD for the reasons mentioned above. Besides, atmos doesn't really have any dependence on external departments so it would be reasonable to have them have to work with someone else for these. |
@Onule They do connect across z-levels so you can use this to send gas to lavaland. |
Balance this shit, make it require a lot of materials and science. |
When has gating things behind science ever been a good way of balancing things? Why is balance even being discussed when nobody has put forth actual problems or test results? You lads are mad. Mad I say! |
Siphoning air from lavaland to refill the station would become practical! |
Only one shared network in the entire game is kinda weird and really limits this, makes using it probably get broken quickly as someone else can take your gas somewhere else, or add bad gas, without needing to know your frequency or whatever. |
I feel like the limited networks are necessary for balance. Also, keep in mind that you can use gas filters to extract only the gas you want to have from the networks, so others can still use the pipes for their own needs. |
Random people dumping plasma into your bluespace pipe setup. |
That sounds like fun, as334. I doubt it would ever happen, but it sounds like fun when it does. Force those techies to use their filters. |
does this have any downside? feels like it could be really strong |
The problem isn't necessarily filters, it's also that someone could just use a really strong pump and suck all the gas away. One solution is to be able to easily find other bluespace pipes with a tool if you have access to one of them, maybe a t-ray scanner. |
Maybe add a range limit to the pipes and only have them share with bluespace pipes nearby within that range? You'd still be able to daisy chain networks together, but sabotage wouldn't be as easy as wrenching down another bluespace pipe anywhere. Also, how about making these very power hungry to balance them? You'd have an incentive to either setup the engine well, or not get too lazy with the piping. You could even have the range depend entirely on how much energy you want to feed the pipe. |
Range limit is probably a good idea as to avoid a 2x1 room with a plasma canister connector and bluespace pump scenario where one asshole floods the station from a room in deep space |
If this is made out of RnD, they are just going to get exploited by ghostroles to steal air, or vice versa grief each other A way to configure seperate channels please but great idea
As to say to the above point, you could have two rooms in space seperated, the airtank is in the leftmost side of the room and you're in the righthand side of the room with a vent, the airtank bluespace pipe is set to port to the nearest bluespace pipe in the eastern direction, and between both bluespace pipes is a window with a LOS and they connect and pipe over automatically with no fuss breathable air into the vent for you in the other room. |
Don't just add them to atmos outright. Though R&D wouldn't be a good answer where to add either. |
Let me throw a questionable idea into the hat: crafting |
@juanototo2 Uses titanium or plastitanium perhaps? |
Please don't gate engineering related things behind mining/science. If you want to gate it, use power instead. Variable power output direly needs some use and RnD and mining have enough things already. |
Mining is supposed to provide for the entire station, not JUST science. Science also in theory is then supposed to provide for the rest of the station too. |
Give engineering a machine, that takes a lot of power to keep the bluespace pipes online, (wire it directly to the engine) |
the problem baw is that science is run by the extremely greedy. Do you remember when they took up mapping to MAP THE MACHINE DIRECTLY INTO R&D? |
Sounds like we should have some administrative action on that then. And also other people do technically have access to the ORM (chemist, and stuff I think) |
ORM should be placed inside cargo and cargo techs should have access. Distributing resources fairly should be cargo's job. |
I'm going to overhaul the mineral refinement/distribution process soon so
let's not use it as a point against this PR
On Sep 21, 2017 4:18 PM, "CPTANT" <notifications@github.com> wrote:
ORM should be placed inside cargo and cargo techs should have access.
Distributing resources fairly should be cargo's job.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#30863 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHyweq18VV_rd3BaBFRv9vB_1utWS6ESks5sksR3gaJpZM4Pa2ef>
.
|
Bluespace pipes
Prepare for a nice helping of burning plasma in your secret bases!! 😈 |
WAAAAHAHAHAHAHA! That is CLASSIC! You do not need Bluespace pipes to do this, but he prooobably ate a ban for doing that as non-antag. Still, 10/10! Stuff like this is why I love this game. (Except the non-antag part) |
The taste for valids was too much to resist |
these are poorly implemented |
you're just now noticing? especially after people cried about wanting channels over and over again... |
these were merged about 2 weeks before i returned i couldn't stop them |
Adds a new unary pipe component: bluespace pipes, which allow one to teleport gas.
The way it works is, every bluespace pipe is implicitly connected to every other bluespace pipe in existence. Pumping gas into one bluespace pipe shares it among all other bluespace pipes.
I'm submitting this as an alternative to #30391, as it addresses some of the problems discussed, such as how awful it is to repair distro once it gets bombed. With bluespace pipes, fixing distro is actually fun!
And let's be honest, connecting pipes over long distances is one of the least functional, and more importantly, least fun aspects of atmospherics. It takes so much time that nobody does it, and that's why you never see clever atmos projects around the station.
Does this make regular pipes redundant?
Hardly. Pipes are far superior at short range because you have control of what they share with. You also have better control over what gases goes where. With bluespace pipes, you only have a single pipenet, so you'll need a bunch of filters and mixers and pumps if you want multiple projects.
How will this change the game
Single-room floods become possible, and you can expect a higher chance of atmospherics getting repaired once broken. Expect to see autism projects make better use of atmos. Expect to see other creative uses (such as using this for cryo).
🆑 Pubby
add: Bluespace pipes to atmospherics, which create a single pipenet with all bluespace pipes in existence.
/:cl: