New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate resizable buffer tests out of staging #3888
base: main
Are you sure you want to change the base?
Conversation
Review ping. |
@syg A few of us have started to review this over the past weeks but unfortunately it's quite large. We're trying to find a way for someone to commit time to it and failing that will otherwise try to split it up between maintainers. Thanks for your patience. |
@ptomato Thanks. If it helps, this PR just splits up existing tests in staging, following the principle that each test262 tests for a single "behavior". |
Another ping. |
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
I created PR #4030 which has a helper file with a lot of the duplicated code from the files in this PR. During the maintainers meeting yesterday we decided that when PR #4030 is merged, I will be removing the duplicated code from the test files of this PR, and will be adding the cleaned up tests to separate smaller PRs, split by method. The goal is to make it easier to split up the review load. When each smaller PR gets merged we plan to rebase this PR so that it keeps getting smaller and we make sure we didn't forget anything. |
…ray buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR tc39#3888).
Collection of helper constants and functions for testing resizable array buffers. These are the parts of the code in RAB staging tests that are heavily repeated. In order to somewhat compact the migration of RAB staging tests (see PR #3888).
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
* RAB: Integrate staging tests for .at method of Array.prototype and TypedArray.prototype This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
of TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
* RAB: Integrate staging tests for .byteLength method of TypedArray.prototype This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
This PR migrates all resizable buffer tests out of staging into the main test suite. Tests that multiple similar methods at once are split up to to multiple files to be consistent with the existing directory structure.
No tests have been removed.
test/built-ins/ArrayBuffer/prototype/resize/coerced-new-length-detach.js
is a new test that tests the normative detach timing change from the July 2023 TC39.