RAB: Integrate staging tests for the .every method #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of Array.prototype and TypedArray.prototype This is part of PR tc39#3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js
ptomato
reviewed
May 8, 2024
ptomato
reviewed
May 10, 2024
Comment on lines
+24
to
+33
| let values; | ||
| let rab; | ||
| let resizeAfter; | ||
| let resizeTo; | ||
| for (let ctor of ctors) { | ||
| rab = CreateRabForTest(ctor); | ||
| const fixedLength = new ctor(rab, 0, 4); | ||
| values = []; | ||
| resizeAfter = 2; | ||
| resizeTo = 5 * ctor.BYTES_PER_ELEMENT; |
There was a problem hiding this comment.
Probably better to scope these values inside the loops, to prevent accidental contamination. It doesn't look like they need to be shared between the loops.
Suggested change
| let values; | |
| let rab; | |
| let resizeAfter; | |
| let resizeTo; | |
| for (let ctor of ctors) { | |
| rab = CreateRabForTest(ctor); | |
| const fixedLength = new ctor(rab, 0, 4); | |
| values = []; | |
| resizeAfter = 2; | |
| resizeTo = 5 * ctor.BYTES_PER_ELEMENT; | |
| for (let ctor of ctors) { | |
| const rab = CreateRabForTest(ctor); | |
| const fixedLength = new ctor(rab, 0, 4); | |
| const values = []; | |
| const resizeAfter = 2; | |
| const resizeTo = 3 * ctor.BYTES_PER_ELEMENT; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of Array.prototype and TypedArray.prototype
This is part of PR #3888 to make reviewing easier. Includes changes to use the helper ./harness/resizableArrayBufferUtils.js