[DependencyInjection] Apply attribute configurator to child classes

[GromNaN]

Q	A
Branch?	7.1
Bug fix?	no
New feature?	yes
Deprecations?	no
Issues	Fix #52898
License	MIT

This allows extending attribute classes registered for autoconfiguration.

Use-case: Share configuration between several classes with pre-configured attribute classes. As described in #52898 (bus name for AsMessageHandler, schedule name for AsCronTask and AsPeriodicTask)

The child-class attribute is handled by the same function as it's parent class that is registered for autoconfiguration. This means any additional property will be ignored (unless supported, which could be new feature for the AsTaggedItem attribute configurator).

If there is a configurator for the child class, the configurator for the parent class is not called.

[chalasr]

Looks sensible to me. I'd suggest checking our current attribute list to make sure there's no blocker in extending each of them (and make those final if any, or hard-skip them)

[GromNaN]

The list of autoconfigured attributes is in FrameworkExtension

• AsEventListener
• AsController
• AsRemoteEventConsumer
• AsMessageHandler
• AsTargetedValueResolver
• AsSchedule
• AsPeriodicTask
• AsCronTask
• Workflow\Attribute\AsAnnounceListener
• Workflow\Attribute\AsCompletedListener
• Workflow\Attribute\AsEnterListener
• Workflow\Attribute\AsEnteredListener
• Workflow\Attribute\AsGuardListener
• Workflow\Attribute\AsLeaveListener
• Workflow\Attribute\AsTransitionListener

[chalasr]

The use case for AsMessageHandler makes sense to me (see linked issue) so I'd be fine reverting the change that made it final, likely for another PR.
For the rest of the attributes I'll let other mergers chime in, but to me all of them feel ok-ish to extend.

[GromNaN]

It will be also possible to remove the handling for all the Workflow attributes, since it duplicates AsEventListener handler.

symfony/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines 1108 to 1129 in bff8e08

	$listenerAttributes = [
	Workflow\Attribute\AsAnnounceListener::class,
	Workflow\Attribute\AsCompletedListener::class,
	Workflow\Attribute\AsEnterListener::class,
	Workflow\Attribute\AsEnteredListener::class,
	Workflow\Attribute\AsGuardListener::class,
	Workflow\Attribute\AsLeaveListener::class,
	Workflow\Attribute\AsTransitionListener::class,
	];
	foreach ($listenerAttributes as $attribute) {
	$container->registerAttributeForAutoconfiguration($attribute, static function (ChildDefinition $definition, AsEventListener $attribute, \ReflectionClass|\ReflectionMethod $reflector) {
	$tagAttributes = get_object_vars($attribute);
	if ($reflector instanceof \ReflectionMethod) {
	if (isset($tagAttributes['method'])) {
	throw new LogicException(sprintf('"%s" attribute cannot declare a method on "%s::%s()".', $attribute::class, $reflector->class, $reflector->name));
	}
	$tagAttributes['method'] = $reflector->getName();
	}
	$definition->addTag('kernel.event_listener', $tagAttributes);
	});
	}

[GromNaN]

All the internal attributes can be extended and we already have an internal use-case with Workflow attributes.

Ready for review.

[fabpot]

Thank you @GromNaN.