Skip to content

Commit

Permalink
feature #54381 [Messenger] Allow extending attribute class `AsMessage…
Browse files Browse the repository at this point in the history
…Handler` (GromNaN)

This PR was merged into the 7.1 branch.

Discussion
----------

[Messenger] Allow extending attribute class `AsMessageHandler`

| Q             | A
| ------------- | ---
| Branch?       | 7.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Issues        | -
| License       | MIT

Revert #52971 which made `AsMessageHandler` final.

Discussed in #54365 (comment)

Commits
-------

9479563 Allow extending AsMessageHandler
  • Loading branch information
nicolas-grekas committed Mar 23, 2024
2 parents e11d75c + 9479563 commit 0b99d83
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 8 deletions.
5 changes: 0 additions & 5 deletions UPGRADE-7.1.md
Expand Up @@ -22,11 +22,6 @@ FrameworkBundle

* Mark classes `ConfigBuilderCacheWarmer`, `Router`, `SerializerCacheWarmer`, `TranslationsCacheWarmer`, `Translator` and `ValidatorCacheWarmer` as `final`

Messenger
---------

* Make `#[AsMessageHandler]` final

SecurityBundle
--------------

Expand Down
Expand Up @@ -14,8 +14,6 @@
/**
* Service tag to autoconfigure message handlers.
*
* @final since Symfony 7.1
*
* @author Alireza Mirsepassi <alirezamirsepassi@gmail.com>
*/
#[\Attribute(\Attribute::TARGET_CLASS | \Attribute::TARGET_METHOD | \Attribute::IS_REPEATABLE)]
Expand Down
1 change: 0 additions & 1 deletion src/Symfony/Component/Messenger/CHANGELOG.md
Expand Up @@ -6,7 +6,6 @@ CHANGELOG

* Add option `redis_sentinel` as an alias for `sentinel_master`
* Add `--all` option to the `messenger:consume` command
* Make `#[AsMessageHandler]` final
* Add parameter `$jitter` to `MultiplierRetryStrategy` in order to randomize delay and prevent the thundering herd effect

7.0
Expand Down

0 comments on commit 0b99d83

Please sign in to comment.