[Yaml] prefix examples with # #54326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Config/Definition/Dumper/YamlReferenceDumper.php
Outdated
Show resolved
Hide resolved
|
This PR changes #39336 behavior. If it is okay the corresponding condition probably need to be removed. |
|
Isn't this issue prior to 7.0? |
xabbuh
approved these changes
Mar 22, 2024
fabpot
approved these changes
Mar 22, 2024
fabpot
force-pushed
the
dump-reference-examples-as-comments
branch
from
5a52070
to
fd95a8f
Compare
|
Thank you @tacman. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2024
…les (MatTheCat) This PR was merged into the 5.4 branch. Discussion ---------- [Config] Fix `YamlReferenceDumper` handling of array examples | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #54326 | License | MIT #54326 was based on a wrong branch. It seems example arrays were considered as default values in some cases. Now that they are displayed as comments, this PR ensures the default value makes sense. Commits ------- 4d4b552 [Config] Fix `YamlReferenceDumper` handling of array examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the issue, the yaml before wasn't valid, as the examples were dumped as an array in the yaml. This simply comments the examples.