[Config] Fix YamlReferenceDumper handling of array examples
#54372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatTheCat
force-pushed
the
config_yaml_dumper
branch
from
48af43b
to
cc30edb
Compare
MatTheCat
force-pushed
the
config_yaml_dumper
branch
from
cc30edb
to
4d4b552
Compare
stof
approved these changes
Mar 22, 2024
chalasr
approved these changes
Mar 22, 2024
fabpot
approved these changes
Mar 23, 2024
|
Thank you @MatTheCat. |
This was referenced Apr 2, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#54326 was based on a wrong branch.
It seems example arrays were considered as default values in some cases. Now that they are displayed as comments, this PR ensures the default value makes sense.