Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] Add assertCommandIsFaulty assertion #52479

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Symfony/Component/Console/CHANGELOG.md
@@ -1,6 +1,11 @@
CHANGELOG
=========

7.1
---

* Add `assertCommandIsFaulty` assertion

7.0
---

Expand Down
@@ -0,0 +1,40 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Console\Tester\Constraint;

use PHPUnit\Framework\Constraint\Constraint;
use Symfony\Component\Console\Command\Command;

final class CommandIsFaulty extends Constraint
{
public function toString(): string
{
return 'is faulty';
}

protected function matches($other): bool
{
return Command::FAILURE === $other || Command::INVALID === $other;
}

protected function failureDescription($other): string
{
return 'the command '.$this->toString();
}

protected function additionalFailureDescription($other): string
{
return Command::SUCCESS === $other
? 'Command was successful.'
: sprintf('Command returned exit status %d.', $other);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be on one line.

}
}
6 changes: 6 additions & 0 deletions src/Symfony/Component/Console/Tester/TesterTrait.php
Expand Up @@ -16,6 +16,7 @@
use Symfony\Component\Console\Output\ConsoleOutput;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Output\StreamOutput;
use Symfony\Component\Console\Tester\Constraint\CommandIsFaulty;
use Symfony\Component\Console\Tester\Constraint\CommandIsSuccessful;

/**
Expand Down Expand Up @@ -104,6 +105,11 @@ public function assertCommandIsSuccessful(string $message = ''): void
Assert::assertThat($this->statusCode, new CommandIsSuccessful(), $message);
}

public function assertCommandIsFaulty(string $message = ''): void
{
Assert::assertThat($this->statusCode, new CommandIsFaulty(), $message);
}

/**
* Sets the user inputs.
*
Expand Down
@@ -0,0 +1,44 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Component\Console\Tests\Tester\Constraint;

use PHPUnit\Framework\ExpectationFailedException;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Tester\Constraint\CommandIsFaulty;

final class CommandIsFaultyTest extends TestCase
{
public function testConstraint()
{
$constraint = new CommandIsFaulty();

$this->assertFalse($constraint->evaluate(Command::SUCCESS, returnResult: true));
$this->assertTrue($constraint->evaluate(Command::FAILURE, returnResult: true));
$this->assertTrue($constraint->evaluate(Command::INVALID, returnResult: true));
}

public function testSuccessfulCommand()
{
$constraint = new CommandIsFaulty();

try {
$constraint->evaluate(Command::SUCCESS);
} catch (ExpectationFailedException $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using expectException() instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense indeed

$this->assertStringContainsString('Failed asserting that the command is faulty.', $e->getMessage());

return;
}

$this->fail();
}
}