Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] Add assertCommandIsFaulty assertion #52479

Closed
wants to merge 1 commit into from
Closed

[Console] Add assertCommandIsFaulty assertion #52479

wants to merge 1 commit into from

Conversation

raphaelstolt
Copy link

@raphaelstolt raphaelstolt commented Nov 7, 2023 •
edited by OskarStark

Q A
Branch? 7.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets #52478
License MIT

Adds the complement of the assertCommandIsSuccessful assertion and improves thereby test readability.

@carsonbot carsonbot added this to the 6.4 milestone Nov 7, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@OskarStark OskarStark modified the milestones: 6.4, 7.1 Nov 7, 2023
@OskarStark OskarStark changed the title [Console] Add missing assertCommandIsFaulty assertion [Console] Add assertCommandIsFaulty assertion Nov 7, 2023
@raphaelstolt raphaelstolt force-pushed the additional-command-faulty-assertion branch from 09a7b78 to f87b71a Compare November 7, 2023 10:19
@symfony symfony deleted a comment from carsonbot Nov 7, 2023
@raphaelstolt
Copy link
Author

Should I rebase?

@OskarStark OskarStark force-pushed the additional-command-faulty-assertion branch from 070f783 to 1fa8c2f Compare December 29, 2023 21:59
@OskarStark OskarStark force-pushed the additional-command-faulty-assertion branch from 1fa8c2f to 37c1e81 Compare December 29, 2023 22:01
@OskarStark
Copy link
Contributor

rebased, squashed ✅

xabbuh
xabbuh reviewed Jan 1, 2024
View reviewed changes
src/Symfony/Component/Console/Tests/Tester/Constraint/CommandIsFaultyTest.php

try {
$constraint->evaluate(Command::SUCCESS);
} catch (ExpectationFailedException $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using expectException() instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense indeed

fabpot
fabpot requested changes Feb 2, 2024
View reviewed changes
src/Symfony/Component/Console/Tester/Constraint/CommandIsFaulty.php
{
return Command::SUCCESS === $other
? 'Command was successful.'
: sprintf('Command returned exit status %d.', $other);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be on one line.

src/Symfony/Component/Console/Tests/Tester/Constraint/CommandIsFaultyTest.php

try {
$constraint->evaluate(Command::SUCCESS);
} catch (ExpectationFailedException $e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense indeed

@fabpot
Copy link
Member

fabpot commented Mar 17, 2024

Closing as there is no more activity and adding another method is maybe not a good idea.

@fabpot fabpot closed this Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh left review comments

@stloyd stloyd stloyd requested changes

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Feature Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@raphaelstolt @carsonbot @OskarStark @fabpot @stloyd @xabbuh @maxbeckers