Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Parcel Locker Brand quest #5638

Merged
merged 3 commits into from
May 16, 2024

Conversation

Arthur-GYT
Copy link
Contributor

@Arthur-GYT Arthur-GYT commented May 13, 2024

All is in the title ^^.

Close #4959

@matkoniecz
Copy link
Member

matkoniecz commented May 13, 2024

For Country Metadata file, do I need to do something ?

See

tasks.register<QLeverCountValueByCountryTask>("updateAtmOperators") {
for existing tasks to fetch them, similar new one should be created (and likely run, to generate file for https://github.com/streetcomplete/StreetComplete/tree/8dbb9e664ad5c3b75a5ed1dddec94e0522940e7b/res/country_metadata )

(there is also NSI but it does not has a full coverage)

@Arthur-GYT Arthur-GYT force-pushed the parcel_locker_brand branch 5 times, most recently from 4aa851e to 3f46b8d Compare May 13, 2024 17:19
@FloEdelmann FloEdelmann added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label May 13, 2024
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side :)

@westnordost
Copy link
Member

Well done! I have only a few small remarks.

Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
@westnordost westnordost merged commit 21c1c3a into streetcomplete:master May 16, 2024
@Arthur-GYT Arthur-GYT deleted the parcel_locker_brand branch May 16, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What's the brand of this parcel locker?
6 participants