-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Parcel Locker Brand quest #5638
Merged
westnordost
merged 3 commits into
streetcomplete:master
from
Arthur-GYT:parcel_locker_brand
May 16, 2024
Merged
Add Parcel Locker Brand quest #5638
westnordost
merged 3 commits into
streetcomplete:master
from
Arthur-GYT:parcel_locker_brand
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See StreetComplete/build.gradle.kts Line 37 in 8dbb9e6
(there is also NSI but it does not has a full coverage) |
matkoniecz
reviewed
May 13, 2024
app/src/main/java/de/westnordost/streetcomplete/quests/QuestsModule.kt
Outdated
Show resolved
Hide resolved
matkoniecz
reviewed
May 13, 2024
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
matkoniecz
reviewed
May 13, 2024
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
5 times, most recently
from
May 13, 2024 17:19
4aa851e
to
3f46b8d
Compare
FloEdelmann
reviewed
May 13, 2024
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
FloEdelmann
added
the
new quest
accepted new quest proposal (if marked as blocked, it may require upstream work first)
label
May 13, 2024
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
from
May 14, 2024 16:54
3f46b8d
to
1c6004c
Compare
FloEdelmann
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from my side :)
FloEdelmann
reviewed
May 14, 2024
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
mnalis
reviewed
May 14, 2024
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
from
May 15, 2024 14:10
1c6004c
to
4890cf6
Compare
westnordost
reviewed
May 15, 2024
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
...c/main/java/de/westnordost/streetcomplete/quests/parcel_locker_brand/AddParcelLockerBrand.kt
Outdated
Show resolved
Hide resolved
Well done! I have only a few small remarks. |
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
from
May 15, 2024 17:08
4890cf6
to
39db254
Compare
westnordost
approved these changes
May 15, 2024
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
from
May 16, 2024 15:34
39db254
to
e710fef
Compare
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
Arthur-GYT
force-pushed
the
parcel_locker_brand
branch
from
May 16, 2024 15:39
e710fef
to
1f4ffd4
Compare
FloEdelmann
approved these changes
May 16, 2024
westnordost
reviewed
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
new quest
accepted new quest proposal (if marked as blocked, it may require upstream work first)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All is in the title ^^.
Close #4959