Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Parcel Locker Pickup/Mail in quest #5639

Merged
merged 2 commits into from
May 16, 2024
Merged

Add Parcel Locker Pickup/Mail in quest #5639

merged 2 commits into from
May 16, 2024

Conversation

Arthur-GYT
Copy link
Contributor

All is in the title ^^

@FloEdelmann FloEdelmann added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label May 13, 2024
@Arthur-GYT Arthur-GYT force-pushed the parcel-locker-pickup-mailin branch from dba5b2d to d117eb2 Compare May 14, 2024 16:55
FloEdelmann
FloEdelmann approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@Arthur-GYT Arthur-GYT force-pushed the parcel-locker-pickup-mailin branch from d117eb2 to d96588b Compare May 15, 2024 06:39
westnordost
westnordost requested changes May 15, 2024
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
res/graphics/quest/parcel_locker.svg Outdated Show resolved Hide resolved
@Arthur-GYT Arthur-GYT force-pushed the parcel-locker-pickup-mailin branch 2 times, most recently from c925bdd to 6b6eb79 Compare May 16, 2024 15:37
@Arthur-GYT
Add Parcel Locker Pickup/Mail in quest
b9d6727 
Signed-off-by: Arthur-GYT <a.gayot@posteo.com>
@Arthur-GYT Arthur-GYT force-pushed the parcel-locker-pickup-mailin branch from 6b6eb79 to b9d6727 Compare May 16, 2024 15:43
@westnordost westnordost merged commit 4d49e0a into streetcomplete:master May 16, 2024
@Arthur-GYT Arthur-GYT deleted the parcel-locker-pickup-mailin branch May 16, 2024 19:33
@westnordost
Copy link
Member

Thank you for these quests!
I gave the arrows some colors to distinguish the icons better and optimized them a bit. (In Inkscape, when you select a group of things, you can union them, so that it is just one polygon in the end. E.g. for the shadow)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FloEdelmann FloEdelmann FloEdelmann approved these changes

@westnordost westnordost westnordost requested changes

Assignees
No one assigned
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Arthur-GYT @westnordost @FloEdelmann