Linux pac drive #1479
Linux pac drive #1479
Conversation
…LinxPacDrive header file. Need to establish how stepmania maps its light values to output, might not need the mapper after converting.
Have now edited the USBDriver_impl.cpp file to directly use libsub, rather than trying to decide by logic, which to try, since we dont need use of the Win32 library for our Linux uses.
…access to USB device, unless using sudo / root privileges.
|
This fails windows and macosx. You also aren't looking for libusb in cmake. Suggest you take a look at the following commits: These should apply to BOTH master and 5_1 new (see the PSTRING definition used to compensate for C/RString and stdstring). I had planned to PR these myself when I exhaustively tested all the cmake stuff but if you want to get everything set to go, use those commits as a guideline to make everything work on all platforms. Your welcome to just cherry pick these if you want and mesh it in. |
|
Hi Chrispable, thanks for the quick feedback. There already is support for Windows for the PAC Drive board using what looks like a dedicated dll library (so i assume this is windows only) 1a09897 Is there a way to use cmake to only compile for Linux? I thought I saw what looked some conditional statements inside the cmake files and I tried to add stuff in to what looked like it was Linux specific. (Apologies I have next to no familiarity with build utilities like cmake as I've been working with interpreted languages and haven't used build tools aside from compiling the odd item for my Linux box using the provided instructions) I guess that an ideal scenario might be to use libusb for all platforms, discounting the need for the dedicated windows only dll. But frankly it's far beyond my current knowledge of C / C++. Though I must admit I wouldn't mind learning, time permitting, especially since I finally made the switch to Linux as my main OS just recently, it would be nice to be able to delve in to the source and understand it better. Out of curiosity the Findlibusb.cmake in your repo, is that OS agnostic? Having so little knowledge of cmake I was struggling to follow it :-( Also could you expand on PSTRING? Is that some form of replacement for the standard C string library? Looking at the build logs from Travis CI it's missing the usb.h Initially I thought about pulling in the file from OpenITG similar to the one you have in your repo. However it looked to me like it was a bit windows specific, and instead I tried installing the 'libusb-dev' package with apt-get, which satisfied the dependency. Not sure how best to approach this issue, I guess it's a bit like adding an extra item to the list of build-tools and libraries required before starting the build as per the instructions https://github.com/stepmania/stepmania/wiki/Compiling-StepMania Would this additional dependency need adding to the Travis CI build to ensure it pulls it in along with the other items it pulls in using apt-get? See line 170 of https://travis-ci.org/stepmania/stepmania/jobs/242347984 |
|
libusb definitely works on windows too, FWIW
…On Tue, Jun 13, 2017, 7:25 AM Craig ***@***.***> wrote:
Hi Chrispable, thanks for the quick feedback.
There already is support for Windows for the PAC Drive board using what
looks like a dedicated dll library (so i assume this is windows only)
1a09897
<1a09897>
Is there a way to use cmake to only compile for Linux? I thought I saw
what looked some conditional statements inside the cmake files and I tried
to add stuff in to what looked like it was Linux specific. (Apologies I
have next to no familiarity with build utilities like cmake as I've been
working with interpreted languages and haven't used build tools aside from
compiling the odd item for my Linux box using the provided instructions)
I guess that an ideal scenario might be to use libusb for all platforms,
discounting the need for the dedicated windows only dll. But frankly it's
far beyond my current knowledge of C / C++. Though I must admit I wouldn't
mind learning, time permitting, especially since I finally made the switch
to Linux as my main OS just recently, it would be nice to be able to delve
in to the source and understand it better.
Out of curiosity the Findlibusb.cmake in your repo, is that OS agnostic?
Having so little knowledge of cmake I was struggling to follow it :-(
Also could you expand on PSTRING? Is that some form of replacement for the
standard C string library?
Looking at the build logs from Travis CI it's missing the usb.h Initially
I thought about pulling in the file from OpenITG similar to the one you
have in your repo. However it looked to me like it was a bit windows
specific, and instead I tried installing the 'libusb-dev' package with
apt-get, which satisfied the dependency. Not sure how best to approach this
issue, I guess it's a bit like adding an extra item to the list of
build-tools and libraries required before starting the build as per the
instructions
https://github.com/stepmania/stepmania/wiki/Compiling-StepMania
Would this additional dependency need adding to the Travis CI build to
ensure it pulls it in along with the other items it pulls in using apt-get?
See line 170 of https://travis-ci.org/stepmania/stepmania/jobs/242347984
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1479 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANZdgpUx6V3btfxfjsRRWoWhXR-A_miks5sDpvbgaJpZM4N4Ovh>
.
|
|
My comments weren't direct to the pacdrive driver, but to the libusb backend. CMAKE must be used for ALL platforms. I am still learning it myself. The commits I linked have the cmake changes needed as well as changes to make the libusb backend work on all 3 platforms, not just linux. In fact, the IO driver that I reverse engineered and wrote a driver for depends on it. The findlibusb is OS agnostic but I feel it could be done better than it is currently. However it DOES work; my dissatisfaction with this module though is the reason why I haven't made a PR just yet. Windows needs (and ALWAYS will need) the lib and h file packaged, hence why its put in extern. PSTRING is basically just a selector for which string to use. openitg uses RSTRING, stepmania 5_1-new uses CString, stepmania master uses stdstring. I use that to pick the proper string for each project; device driver registration differs too so you can use the same logic to create a driver that works on the same conditional logic, which is what I was getting at. Travis is setup to a specific build environment, it would need to be modified to have the libusb-dev package. Thats where the linux version of usb.h comes from. |
|
I have setup with linux + openitg beta 2 + pacdrive, and I can confirm that it works. So, if stepmania will merge this somehow or implement pacdrive for linux, I can test it. |
|
I built stepmania with these changes based on 5_1-new branch. And it works! |
|
Per jsirex findings, does this require further testing? |
|
Tested and confirmed working. Video proof https://youtu.be/OYs63xCk5d4 |
|
Adding "usb" to CMakeLists.txt in the SMDATA_LINK_LIB causes a linker error on Windows. |
|
...any reason this wasn't merged? I got some messages about this. |
I'm not aware of any specific reason, so I'll guess it was the usual inertia. It looks like @jsirex merged these commits into @RhythmLunatic later confirmed that these commits worked for Linux, and found that they introduced a linker error on Windows. I'll assume from @DinsFire64's question that Linux Pac-Drive support is still wanted. Can anyone: |
|
Not sure "usb" is required in the cmake in the first place, since I took it out and it still works. But my fork already had libusb0 implemented so there might be libusb stuff somewhere else
|
|
Thanks for this information, @RhythmLunatic. I am inferring from your first item that these changes would add I can attempt to pull these commits into 5_1-new and then try to build on Linux and macOS, but I don't have a Pac-Drive, any familiarity with how Pac-Drives work, or what I would even be looking to test. |
|
Libusb dependancy should already set in cmake for p3io functionally. I
don't recall if sm5 merged that in, but if not you can cherry pick it to
save the effort
|
|
libusb isn't merged as far as I know. But this PR introduces it. It might be better to redo the PR using the starworlds fork for libusb since it doesn't produce any errors. @dguzek yes, those are the dependencies needed to compile on Linux. |
@chrispable - Do you have interest + time to pull request P3IO/P2IO support from starworlds to upstream? If not, do you have any pointers on how someone might get started bringing the work in? Support in upstream has been asked about, and preliminary efforts to cherry-pick your work in suggested there might be some additional configuration needed. It's not directly related to Linux PAC Drive support in SM5.1 (this PR), but it would help put some required pieces in place. |
|
You should just be able to take the full commits from the fork and replay them on top of your branch of choice. There's a few things here i want to point out. P2io support has since also been added but there's a myriad of configurations that are not tested (but in theory should work). I also wanted to make board detection and setup better (for example if you didn't specify extio light driver, attempt to use the one in the p2io, do node checks for devices instead of using node numbers on hdxb, better detection of hd or sd button modes, etc) and some code cleanup. I currently don't have access to what I need due to the pandemic (hopefully I will in a few months, io is locked in a school rec room and no entry allowed) and have personal issues currently to devote the time (and lack of personal computer) to make it as user friendly and clean as I wanted it to be. It was my hope that someone would take my work and bring it that last mile. I also really did want to add the signal divider code to use the p2ios magic 15khz circuit for legacy cabinets (but also wasn't given a cable to do that) I think I also started adding rgb support to lightsman so everyone can use rgb but I don't recall if I ever finished. If it gets merged as is, and your fine with a cleanup pr whenever I get to it, by all means please create that pr. Just grab and squash everything after the fork. While I'm proud of the functionality, let it be known I am not fond of the code quality or I'd have done it myself. |
Hi,
I needed Linux support for the PAC Drive board (https://www.ultimarc.com/pacdrive.html)
I noticed on some forums that OpenITG had support, so I pulled in the files and modified them as required. I haven't done much C or C++ since leaving college 20 years ago, and I'm not massively familiar with make files etc... So I hope the relevant lines have been added to the most appropriate sections of the make files.
It feels like it might be a bit hacked together, but on my machine (Ubuntu 16.04) the USB device is found and functions. It does require a udev rule to assign group access to the USB device or root / sudo privileges when executing Stepmania otherwise, I prefer the udev rule. Additionally I needed to install the libusb-dev package via apt-get for compilation.
I hope it's useful, Craig.