-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Linux PacDrive + Libusb Drivers #69
Conversation
9530636
to
d51bf50
Compare
"archutils/Unix/arch_setup.h" | ||
"archutils/Unix/AssertionHandler.h" | ||
"archutils/Unix/EmergencyShutdown.h" | ||
"archutils/Unix/GetSysInfo.h" | ||
"archutils/Unix/RunningUnderValgrind.h" | ||
"archutils/Unix/SignalHandler.h" | ||
"archutils/Unix/SpecialDirs.h" | ||
"archutils/Common/gcc_byte_swaps.h") | ||
"archutils/Common/gcc_byte_swaps.h" | ||
"io/USBDriver.h") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libusb-dev needs to be added to the build pipeline
{ | ||
#if defined(HAS_USBDRIVER_IMPL_LIBUSB) | ||
return new USBDriver_Impl_Libusb; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could just always use libusb for all platforms. That way we could get rid of the dispatch mechanism and remove two of the files.
list(APPEND SMDATA_ARCH_LIGHTS_HPP | ||
"arch/Lights/LightsDriver_Linux_Leds.h" | ||
"arch/Lights/LightsDriver_Linux_PIUIO.h" | ||
"arch/Lights/LightsDriver_Linux_PIUIO_Leds.h" | ||
"arch/Lights/LightsDriver_Linux_PIUIOBTN_Leds.h" | ||
"arch/Lights/LightsDriver_Linux_ITGIO.h" | ||
"arch/Lights/LightsDriver_Linux_stac.h" | ||
"arch/Lights/LightsDriver_LinuxWeedTech.h") | ||
"arch/Lights/LightsDriver_LinuxPacDrive.cpp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.h
Maybe you'll be interested in simplified linux pacdrive backport. I tested it on stepmania: 5_1 branch. Also, udev rule so no root required:
idProduct sometimes changes. I have couple devices. |
I think I might delegate to @DinsFire64 and see if they have a preference on the implementation used for the Linux PacDrive |
I often have to backport this, so decided to simplify the implementation, because whole job had to be done here is just write a couple bytes to device via usb_control_msg. No need that complecated Driver -> UBSDriver -> PacDrive. Also I made it optional via CMAKE. However there aren't wire mapping configuration. So feel free to use any approach, copy-paste/merge solutions. |
Superseded by #77 |
Largely originates from stepmania/stepmania#1479 so see that thread for context.