Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous function call on Windows #2155

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Fix ambiguous function call on Windows #2155

merged 3 commits into from
Feb 13, 2024

Conversation

jorisv
Copy link
Contributor

@jorisv jorisv commented Feb 12, 2024

Call pinocchio::isNormalized intead of isNormalized that it seen ambiguous by MSVC (LieGroupBase or namespace).

Close #2154

@jorisv jorisv self-assigned this Feb 12, 2024
@jorisv jorisv linked an issue Feb 12, 2024 that may be closed by this pull request
Call non-static member function isNormalized() in static function integrate_impl() #2154
Closed
@jorisv jorisv marked this pull request as ready for review February 13, 2024 09:02
@jorisv jorisv merged commit 07e8b00 into stack-of-tasks:devel Feb 13, 2024
20 of 22 checks passed
@jorisv jorisv deleted the topic/fix_windows_debug branch February 13, 2024 09:09
@jorisv jorisv mentioned this pull request Feb 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcarpent jcarpent jcarpent approved these changes

Assignees

@jorisv jorisv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call non-static member function isNormalized() in static function integrate_impl()
2 participants
@jorisv @jcarpent