Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(api): change FiatPermissionEvaluator to implement UserPermis… #1155

Merged
merged 2 commits into from
Apr 27, 2024

Commits on Apr 26, 2024

  1. refactor(api): change FiatPermissionEvaluator to implement UserPermis…

    …sionEvaluator
    
    instead of PermissionEvaluator, and mark
    
    public boolean hasPermission(
          String username, Serializable resourceName, String resourceType, Object authorization)
    
    as @OverRide.
    
    This makes this method available to e.g. S3ArtifactStoreGetter so it can authenticate by
    user.  In some pipeline execution scenarios in orca (e.g. using #fetchReference in an
    Evaluate Variables stage), this is necessary since SecurityContextHolder.getContext() is
    null.
    dbyron-sf committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    02d947d View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2024

  1. Configuration menu
    Copy the full SHA
    c05fe60 View commit details
    Browse the repository at this point in the history