refactor(api): change FiatPermissionEvaluator to implement UserPermis… #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sionEvaluator
instead of PermissionEvaluator, and mark
public boolean hasPermission(
String username, Serializable resourceName, String resourceType, Object authorization)
as @OverRide.
This makes this method available to e.g. S3ArtifactStoreGetter so it can authenticate by
user. In some pipeline execution scenarios in orca (e.g. using #fetchReference in an
Evaluate Variables stage), this is necessary since SecurityContextHolder.getContext() is
null.
xibz
approved these changes
Apr 26, 2024
|
@Mergifyio update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sionEvaluator
instead of PermissionEvaluator, and mark
as
@Override.This makes this method available to e.g. S3ArtifactStoreGetter so it can authenticate by user. In some pipeline execution scenarios in orca (e.g. using #fetchReference in an Evaluate Variables stage), this is necessary since SecurityContextHolder.getContext() is null.
depends on spinnaker/kork#1179.