-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config simplifications #1096
Open
jvz
wants to merge
12
commits into
spinnaker:master
Choose a base branch
from
jvz:config-simplifications
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Config simplifications #1096
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a7441fc
refactor(web): Remove unnecessary import
jvz 050734a
refactor(web): Simplify RetrofitConfig
jvz cbe0d15
refactor(web): Simplify FiatConfig
jvz 7e5f07e
refactor(web): Simplify ResourcesConfig
jvz 06c5ef6
refactor(api): Simplify FiatAuthenticationConfig
jvz 0e302d8
fix(api): Use same anonymous principal as Gate
jvz 735abc1
Merge branch 'master' into config-simplifications
jvz d36e939
Merge branch 'master' into config-simplifications
jasonmcintosh dca80be
Merge branch 'master' into config-simplifications
jvz 8b1253a
Merge branch 'master' into config-simplifications
jasonmcintosh 8f25053
Merge branch 'master' into config-simplifications
jasonmcintosh 723eade
Merge branch 'master' into config-simplifications
jasonmcintosh File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this ends up with RetrofitServiceFactory creating the returned object. At the moment that code doesn't use
so this ends up being a change in behavior. Adding the setErrorHandler call to RetrofitServiceFactory is in the plans, but is gonna take some care (and potentially a config flag controlling whether it happens or not) since I believe both gate and echo use it, and we need to coordinate changes in handling of RetrofitError to Spinnaker*Exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't the new error handler for running in Retrofit2? Right now,
ServiceClientFactory
implementations check for the use of theCall<T>
API for determining which Retrofit version to use.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SpinnakerRetrofitErrorHandler is for retrofit1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But Retrofit only throws
RetrofitError
in the first place?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, retrofit1 throws RetrofitError, and SpinnakerRetrofitErrorHandler turns RetrofitError into SpinnakerServerException (and children).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, so the point of the error handler Bean is to translate the retrofit exception into a spinnaker one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a bean, but yes.