-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config simplifications #1096
base: master
Are you sure you want to change the base?
Config simplifications #1096
Commits on Aug 25, 2023
-
refactor(web): Remove unnecessary import
`ErrorConfiguration` is already found during component-scanning of `com.netflix.spinnaker.config`.
Configuration menu - View commit details
-
Copy full SHA for a7441fc - Browse repository at this point
Copy the full SHA a7441fcView commit details -
refactor(web): Simplify RetrofitConfig
- Use parameter injection for config properties that are still used - Delete the unused properties that were injected - Use a `Jackson2ObjectMapperBuilder` bean to simplify setup of the default `ObjectMapper`
Configuration menu - View commit details
-
Copy full SHA for 050734a - Browse repository at this point
Copy the full SHA 050734aView commit details -
refactor(web): Simplify FiatConfig
- Implement `WebMvcConfigurer` instead of extending the now deprecated `WebMvcConfigurerAdapter` class - Use `List::of` instead of `ImmutableList::of` - Remove call to `ContentNegotiationConfigurer::favorPathExtension` as this value has been the default in Spring for a while now - Replace `val` with `var` keyword - Fix some grammar in docs
Configuration menu - View commit details
-
Copy full SHA for cbe0d15 - Browse repository at this point
Copy the full SHA cbe0d15View commit details -
refactor(web): Simplify ResourcesConfig
Use `ServiceClientProvider` from `kork-web` to create Retrofit proxy beans for `Front50Api`, `ClouddriverApi`, and `IgorApi`. Other Retrofit settings repeatedly configured here are already configured in the relevant `ServiceClientFactory` ultimately used by `ServiceClientProvider`.
Configuration menu - View commit details
-
Copy full SHA for 7e5f07e - Browse repository at this point
Copy the full SHA 7e5f07eView commit details -
refactor(api): Simplify FiatAuthenticationConfig
- Use `ServiceClientProvider` from `kork-web` to create a Retrofit proxy bean for `FiatService` - Use `Jackson2ObjectMapperBuilder` to create the `ObjectMapper` used for `FiatService` - Use `withDefaults()` customizer to simplify security configuration chains
Configuration menu - View commit details
-
Copy full SHA for 06c5ef6 - Browse repository at this point
Copy the full SHA 06c5ef6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e302d8 - Browse repository at this point
Copy the full SHA 0e302d8View commit details
Commits on Aug 31, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 735abc1 - Browse repository at this point
Copy the full SHA 735abc1View commit details
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d36e939 - Browse repository at this point
Copy the full SHA d36e939View commit details
Commits on Sep 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dca80be - Browse repository at this point
Copy the full SHA dca80beView commit details
Commits on Oct 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b1253a - Browse repository at this point
Copy the full SHA 8b1253aView commit details
Commits on Oct 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8f25053 - Browse repository at this point
Copy the full SHA 8f25053View commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 723eade - Browse repository at this point
Copy the full SHA 723eadeView commit details