Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config simplifications #1096

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Commits on Aug 25, 2023

  1. refactor(web): Remove unnecessary import

    `ErrorConfiguration` is already found during component-scanning of `com.netflix.spinnaker.config`.
    jvz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    a7441fc View commit details
    Browse the repository at this point in the history
  2. refactor(web): Simplify RetrofitConfig

    - Use parameter injection for config properties that are still used
    - Delete the unused properties that were injected
    - Use a `Jackson2ObjectMapperBuilder` bean to simplify setup of the default `ObjectMapper`
    jvz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    050734a View commit details
    Browse the repository at this point in the history
  3. refactor(web): Simplify FiatConfig

    - Implement `WebMvcConfigurer` instead of extending the now deprecated `WebMvcConfigurerAdapter` class
    - Use `List::of` instead of `ImmutableList::of`
    - Remove call to `ContentNegotiationConfigurer::favorPathExtension` as this value has been the default in Spring for a while now
    - Replace `val` with `var` keyword
    - Fix some grammar in docs
    jvz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    cbe0d15 View commit details
    Browse the repository at this point in the history
  4. refactor(web): Simplify ResourcesConfig

    Use `ServiceClientProvider` from `kork-web` to create Retrofit proxy beans for `Front50Api`, `ClouddriverApi`, and `IgorApi`. Other Retrofit settings repeatedly configured here are already configured in the relevant `ServiceClientFactory` ultimately used by `ServiceClientProvider`.
    jvz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    7e5f07e View commit details
    Browse the repository at this point in the history
  5. refactor(api): Simplify FiatAuthenticationConfig

    - Use `ServiceClientProvider` from `kork-web` to create a Retrofit proxy bean for `FiatService`
    - Use `Jackson2ObjectMapperBuilder` to create the `ObjectMapper` used for `FiatService`
    - Use `withDefaults()` customizer to simplify security configuration chains
    jvz committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    06c5ef6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0e302d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2023

  1. Configuration menu
    Copy the full SHA
    735abc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    d36e939 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    dca80be View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2023

  1. Configuration menu
    Copy the full SHA
    8b1253a View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Configuration menu
    Copy the full SHA
    8f25053 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Configuration menu
    Copy the full SHA
    723eade View commit details
    Browse the repository at this point in the history