Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image Captions on Thumbnail View #77

Open
wants to merge 8 commits into
base: improve-build
Choose a base branch
from
+118 −87
Open

Add Image Captions on Thumbnail View #77

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d395588
Adjust formatting
youngjames Dec 20, 2023
260970d
Conditionally render captions under images (grid and single)
youngjames Dec 20, 2023
ac142db
Fix formatting
youngjames Dec 20, 2023
6b611ba
Update guide with image caption setting
youngjames Dec 20, 2023
e1d8c84
Fix typo
youngjames Dec 20, 2023
17a38a1
Replace *all* instances of newline chars with line break element...
youngjames Feb 6, 2024
d628eac
Use grid layout for thumbnail view wrapper
youngjames Feb 6, 2024
aec6702
Bump line height for improved readability
youngjames Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion PortalApp/app/view/ThumbnailView.js
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, but we realized that the previous change was not working properly for cases where more than two fields were configured for imageInfoFlds. This should address that.

Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Ext.define('SpWebPortal.view.ThumbnailView', {
prepareData: function (data) {
Ext.apply(data, {
shortName: Ext.util.Format.ellipsis(data.Title, 15),
AttachedToDescrFormatted: data.AttachedToDescr.replace('\n', '<br>')
AttachedToDescrFormatted: data.AttachedToDescr.split('\n').join('<br>')
})
return data
},
Expand Down