Add Image Captions on Thumbnail View #77
Conversation
There was a problem hiding this comment.
It looks like this PR includes the changes for #76 as well as the changes to add image captions in thumbnail views.
I really appreciate the way this was added (adding a new setting named displayImgCaption that can be toggled on or off) to make it simple and optional for users. Great work and thank you so much @warrenhbrown!
PortalApp/index.html
Outdated
| @@ -81,6 +81,9 @@ | |||
| <script type="text/javascript" src="//maps.googleapis.com/maps/api/js?key=AIzaSyDYHJjsVAniNFUxSZnIO6pyVBxBqRt9gmw&sensor=false"></script> | |||
| <!--script type="text/javascript" src="//maps.google.com/maps/api/js?sensor=false"></script--> | |||
|
|
|||
| <!-- Google Tag Manager --> | |||
There was a problem hiding this comment.
It looks like the same changes are made on #76
webportal-installer/PortalApp/index.html
Lines 84 to 85 in 856d639
There was a problem hiding this comment.
Thanks for catching that @melton-jason — it looks like we had some extraneous merge commits from one of our other branches that was not intended to be a part of this feature branch. I have removed those commits and hopefully there are no longer any overlapping/out-of-sync concerns.
|
@specify/dev-testing This code is live on their Fish Web Portal. When testing, we need to set up a new instance and verify that the |
youngjames
force-pushed
the
spec-image-captions
branch
from
58672e7
to
e1d8c84
Compare
...not just the first.
The current float-based layout for image thumbnails results in irregular gaps due to the variability in image caption height.
There was a problem hiding this comment.
Here's an example of the layout issue we observed due to longer caption lengths that affect rendering height. The existing css float rule remains in place to support older browsers, if needed.
Commit w/ potential fix: d628eac
There was a problem hiding this comment.
Apologies, but we realized that the previous change was not working properly for cases where more than two fields were configured for imageInfoFlds. This should address that.
This pull request adds support for displaying a caption under the images in the thumbnail view. settings.json is extended with: displayImgCaption: when set to true, the fields (as configured in imageInfoFlds, see above) will render underneath preview views and the image detail view.