Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrappers: proxy missing enable+disabledSvcs to service agent #13957

Merged

Conversation

Meulengracht
Copy link
Member

This properly proxies the enable request to the user-session agent, along with the disabled-services for user services (however not used yet, will be used by #13905)

Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

wrappers/services.go Outdated Show resolved Hide resolved
wrappers/services.go Show resolved Hide resolved
@Meulengracht Meulengracht requested a review from ernestl May 30, 2024 12:23
Change error messages  to be lowercase, add comments on behaviour
@Meulengracht Meulengracht force-pushed the feature/enable-svcs-user-agent branch from 7f8894d to 6a3f1e0 Compare May 30, 2024 12:31
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

Copy link
Collaborator

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Meulengracht Meulengracht merged commit a911da3 into snapcore:master Jun 6, 2024
39 of 49 checks passed
@Meulengracht Meulengracht deleted the feature/enable-svcs-user-agent branch June 6, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants