o/snapstate: support user-services when refreshing snaps #13905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meulengracht
force-pushed
the
feature/refresh-user-services-support
branch
from
6908f90
to
1762c26
Compare
Meulengracht
force-pushed
the
feature/refresh-user-services-support
branch
from
ef0cd88
to
fa70343
Compare
Meulengracht
force-pushed
the
feature/refresh-user-services-support
branch
from
fa70343
to
7a3d4e1
Compare
|
I dropped the spread test I was doing, we were already covering this functionality in the unit tests - and extending them to cover the user services part made sense. |
pedronis
reviewed
May 2, 2024
overlord/snapstate/handlers.go
Outdated
| // Insert it into the overview, into the 'found' list. Re-use the entire | ||
| // list for all users (-1) as there won't be any difference between users | ||
| // in this specific case (and to allow us to keep a singular list of services | ||
| // that need to be disabled). |
There was a problem hiding this comment.
this comment is not very clear, can we use a single list because hooks cannot target single users via snapctl commands?
There was a problem hiding this comment.
Your comment let me to a missing case of support for user-services. The service tracking code for hooks did not account for user-services - I added this in here, as it is required for completeness in the refresh handling.
Meulengracht
force-pushed
the
feature/refresh-user-services-support
branch
from
5fd71d8
to
abe095c
Compare
|
I split out the wrapper changes: #13957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the remaining functionality to support user-services when refreshing snaps. SnapState now also keeps track of the last disabled services for user-services.