Free up the getDescription method to prevent it overriding db fields

[michalkleiner]

The getDescription method is potentially overriding a Description db field on any extending class.

The method was used only to get an addition to getTypeNice to display in the gridfield, possibly translated.

Let me know if this needs to be targetted at any other branch as it might be seen as a BC issue, should someone use this public, though otherwise quite narrow-focused, method somewhere else.

Issue

• Remove the getDescription method from BaseElement #1106

[ScopeyNZ]

Unfortunately we can't break SemVer justified by the likelihood of someone (not) using the API, as much as I wish that were true. This will have to be a change targeted at master. You're welcome to do a BC PR, that deprecates the method. You can leave in the changes made to ::getTypeNice too.

[emteknetnz]

This pull request hasn't had any activity for a while. Are you going to be doing further work on it, or would you prefer to close it now?

[michalkleiner]

Yes @emteknetnz, I'll rebase and retarget the PR.

[emteknetnz]

@michalkleiner are you still interested in this one? I have no idea when the next major version of elemental will be released

[michalkleiner]

@emteknetnz can we merge as is since it now targets master? At least that won't get lost. I may then raise a separate PR deprecating the method.

[emteknetnz]

I'm OK with that, link through the deprecation PR and I'll merge this as is

[michalkleiner]

@emteknetnz — #953