Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the getDescription method from BaseElement #1106

Open
GuySartorelli opened this issue Oct 9, 2023 · 0 comments
Open

Remove the getDescription method from BaseElement #1106

GuySartorelli opened this issue Oct 9, 2023 · 0 comments
Assignees
@GuySartorelli
Labels
impact/medium type/api-break
Milestone
Silverstripe CMS 6

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 9, 2023 •
edited

The getDescription method is potentially overriding a Description db field on any extending class.

The method was used only to get an addition to getTypeNice to display in the gridfield, possibly translated.

PRs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuySartorelli GuySartorelli

Labels
impact/medium type/api-break
Projects
None yet
Milestone
Silverstripe CMS 6
Development

No branches or pull requests
1 participant
@GuySartorelli