Fix issue where Graph could not be created with empty extent #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aalexsmithh
changed the title
This was referenced Jun 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change fixes an issue where a Graph could not be created with an empty extent. The bug has been mentioned here (#92) and here (#90), and I was experiencing it myself when using the
matchcommand.It looks like a check was added for an empty extent at some point with this commit: fix error handling for empty tiles but the null check need to be moved to a point before any turf packages were invoked. It is possible that turf had null checks in their methods at some point in the past but has removed them, causing the issue described.
I tested this with the tests included and with my own data, and the Graph should now be able to be created with an empty extent.