Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-1434: shst matching robustness improvements #4

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

edmabon
Copy link

@edmabon edmabon commented Jan 12, 2024

Ticket

I was seeing some failed matches, even when I'd expect a good match just from looking at the trace, and by running OSRM matching directly. There were quite strict constraints on post-processing the OSRM output, and so I have loosened those off a little bit to give us more robustness in the output.

I will comment on the specific individual changes.

For testing, you can use this trace and run the matching on this branch vs the main branch to see the difference:

docker run -it --rm -v ${PWD}:/work --env SHST_TILE_URL=https://rr-binaries.s3.eu-west-2.amazonaws.com/tiles/ shst-image match /work/test.geojson --tile-source=osm/planet-240104 --search-radius=25 --follow-line-direction
{
  "type": "FeatureCollection",
  "features": [
    {
      "type": "Feature",
      "properties": {},
      "geometry": {
        "type": "LineString",
        "coordinates": [
          [
            -0.2094627999999993,
            52.5977402
          ],
          [
            -0.20944320000000027,
            52.59764479999999
          ],
          [
            -0.20948560000000072,
            52.598114
          ],
          [
            -0.21030939999999987,
            52.598419199999995
          ],
          [
            -0.21161750000000076,
            52.59839629999999
          ],
          [
            -0.22327850000000107,
            52.6007805
          ],
          [
            -0.22510950000000032,
            52.60230259999999
          ],
          [
            -0.22987429999999948,
            52.60523220000001
          ],
          [
            -0.23804459999999988,
            52.60895539999999
          ],
          [
            -0.24569849999999904,
            52.61297230000001
          ],
          [
            -0.24825579999999914,
            52.614566800000006
          ],
          [
            -0.24752409999999983,
            52.614574399999995
          ],
          [
            -0.24688100000000002,
            52.61516189999999
          ],
          [
            -0.24682960000000137,
            52.6155472
          ],
          [
            -0.24776610000000016,
            52.6158524
          ],
          [
            -0.24778540000000043,
            52.61575319999999
          ]
        ]
      }
    }
  ]
}

src/tiles.ts Show resolved Hide resolved
src/graph.ts Show resolved Hide resolved
src/graph.ts Show resolved Hide resolved
@mandu
Copy link

mandu commented Jan 12, 2024

Thanks @edmabon for clear comments!

@edmabon edmabon merged commit 84a29ac into master Jan 12, 2024
@edmabon edmabon deleted the ART-1434 branch January 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants