ART-1434: shst matching robustness improvements #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
I was seeing some failed matches, even when I'd expect a good match just from looking at the trace, and by running OSRM matching directly. There were quite strict constraints on post-processing the OSRM output, and so I have loosened those off a little bit to give us more robustness in the output.
I will comment on the specific individual changes.
For testing, you can use this trace and run the matching on this branch vs the main branch to see the difference: