Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TCP retransmissions #4224

Merged
merged 1 commit into from Apr 28, 2024
Merged

Fix TCP retransmissions #4224

merged 1 commit into from Apr 28, 2024

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Jan 20, 2024 •
edited

@gpotter2 gpotter2 mentioned this pull request Jan 20, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Jan 20, 2024 •
edited

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 82.17%. Comparing base (bcf500d) to head (94db327).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4224      +/-   ##
==========================================
+ Coverage   82.12%   82.17%   +0.04%     
==========================================
  Files         350      350              
  Lines       83242    83269      +27     
==========================================
+ Hits        68364    68427      +63     
+ Misses      14878    14842      -36
Files Coverage Δ
scapy/layers/http.py 82.38% <100.00%> (+0.10%) ⬆️
scapy/sessions.py 95.40% <55.55%> (-1.97%) ⬇️

... and 14 files with indirect coverage changes

@gpotter2 gpotter2 marked this pull request as draft January 20, 2024 15:58
@gpotter2 gpotter2 marked this pull request as ready for review April 27, 2024 21:25
@gpotter2 gpotter2 added the bug label Apr 27, 2024
@gpotter2 gpotter2 added this to the 2.6.0 milestone Apr 27, 2024
@gpotter2 gpotter2 merged commit 8bb5ba3 into secdev:master Apr 28, 2024
23 checks passed
@gpotter2 gpotter2 deleted the tcpsession-fix-retransmit branch April 28, 2024 18:04
@gpotter2
Improve TCPSession retransmission handling
94db327 
- fixes secdev#4197
- also fixes secdev#4340: handling of HTTP reconstruction when gzip is involved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.

TCPSession rebuild http session bug TCP Retransmission causes scapy to exit
1 participant
@gpotter2