Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TCP Retransmission causes scapy to exit #4197

Closed
stulle123 opened this issue Nov 27, 2023 · 1 comment · Fixed by #4224
Closed

TCP Retransmission causes scapy to exit #4197

stulle123 opened this issue Nov 27, 2023 · 1 comment · Fixed by #4224

Comments

@stulle123
Copy link

Brief description

Hi,

I have a pcap file where a TCP Retransmission (the 7th packet) causes scapy to exit with the following error message: WARNING: Socket <scapy.utils.PcapReader object at 0x000001FE8B3192D0> failed with 'not enough values to unpack (expected 3, got 2)'. It was closed.

Scapy stops processing the pcap file after that.

The bug was introduced with #4082.

Cheers,

stulle123

Scapy version

2.5.0.dev157

Python version

3.11.2

Operating system

Windows 10

Additional environment information

No response

How to reproduce

from scapy.config import conf
from scapy.main import load_layer
from scapy.sendrecv import sniff
from scapy.sessions import TCPSession

conf.tls_session_enable = True
load_layer("tls")

capture = sniff(
    offline="bar.pcap",
    session=TCPSession,
)

Actual result

No response

Expected result

No response

Related resources

No response

@gpotter2
Copy link
Member

Should be fixed in #4224

gpotter2 added a commit to gpotter2/scapy that referenced this issue Apr 27, 2024
- fixes secdev#4197
- also fixes secdev#4340: handling of HTTP reconstruction when gzip is involved
gpotter2 added a commit that referenced this issue Apr 28, 2024
- fixes #4197
- also fixes #4340: handling of HTTP reconstruction when gzip is involved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants