Add resolve feature #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2016
|
Add a test and I'll merge. Thanks :) |
|
@ryanflorence Added |
| ]) | ||
|
|
||
| function resolver(Component, params, cb) { | ||
| Component.loadProps(params, cb, 'check') |
There was a problem hiding this comment.
this would pass even w/o your changes, right? Maybe switch the name from loadProps to resolveProps or something.
There was a problem hiding this comment.
It's impossible. there a lot of places where we are checking that loadProps method exists
We need to use this method now...
There was a problem hiding this comment.
this will work only with resolver feature
|
@ryanflorence Done, check it please... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we can control Components interface for loading async data