Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on promise in addition to callback #17

Closed
jorrit opened this issue Dec 23, 2015 · 3 comments
Closed

Wait on promise in addition to callback #17

jorrit opened this issue Dec 23, 2015 · 3 comments

Comments

@jorrit
Copy link

jorrit commented Dec 23, 2015

The current implementation only supports rendering after loadProps invokes a callback. Wouldn't it be an interesting addition to also support loadProps returning a Promise and render after the promises resolve?

@ryanflorence
Copy link
Owner

Gonna keep it simple and stick with callbacks.

I'd be more interested in figuring out some API to let you plug in this kind of behavior.

@ryanflorence
Copy link
Owner

Like, maybe its just a prop like resolve here: https://github.com/rackt/async-props/blob/master/modules/AsyncProps.js#L184

@sars
Copy link

sars commented Jan 15, 2016

@jorrit @ryanflorence This should fix this problem #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants