Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double output when playing with --clock in rosbag containing clock #1645

Open
kosuke55 opened this issue May 8, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@kosuke55
Copy link
Contributor

kosuke55 commented May 8, 2024

Description

If we play rosbag containing /clock with the --clock option, we will get double /clock output.

ros2 topic echo /clock

---
clock:
  sec: 1715138101
  nanosec: 880998015
---
clock:
  sec: 1666578700
  nanosec: 606046430
---
clock:
  sec: 1666578700
  nanosec: 608539499
---
clock:
  sec: 1715138101
  nanosec: 891000787
---
clock:
  sec: 1666578700
  nanosec: 611041316

Completion Criteria

only one /clock is published

Implementation Notes / Suggestions

If --clock is specified, how about excluding /clock? (#1646)

        if play_options.clock_publish_frequency > 0:
            play_options.exclude_topics_to_filter.append('/clock')

Testing Notes / Suggestions

play rosbag containing /clock with --clock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant