Port hd_monitor to ROS2 #334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @limaanto :) |
limaanto
force-pushed
the
port-hd-monitor
branch
from
5c0891a
to
c6fb93c
Compare
|
Hi, I rebased the branch on |
ct2034
requested changes
May 13, 2024
Comment on lines
+51
to
+52
| FREE_PERCENT_LOW = 0.05 | ||
| FREE_PERCENT_CRIT = 0.01 |
There was a problem hiding this comment.
this should be configurable
Comment on lines
+98
to
+101
| KeyValue(key=f'Name', value=self._path), | ||
| KeyValue(key=f'Status', value=DICT_STATUS[diag.level]), | ||
| KeyValue(key=f'Total (Go)', value=str(total_Go)), | ||
| KeyValue(key=f'Available (%)', value=str(round(percent, 2))), |
There was a problem hiding this comment.
These don't have to be f-strings
| ]) | ||
|
|
||
| diag.message = DICT_USAGE[diag.level] | ||
| print(diag) |
| def check_disk_usage(self, diag: DiagnosticStatus) -> DiagnosticStatus: | ||
| diag.level = DiagnosticStatus.OK | ||
|
|
||
| total, used, free = disk_usage(self._path) |
There was a problem hiding this comment.
Suggested change
| total, used, free = disk_usage(self._path) | |
| total, _, free = disk_usage(self._path) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised in #319 (though it took quite a while..), here is a ported version of the HD monitor script.
After the discussions of #319, I decided to :
shutil.disk_usagewhich comes with all python installs seemed like a good choicepathto configure where the check is ran on. By default this is the home directory but can be changed with a ros paramI did not take the time to write the test yet, let me know if this is mandatory for merging (or if there is any other point for that matter)