Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ros2cli diagnostics tool #328

Draft
wants to merge 26 commits into
base: ros2
Choose a base branch
from
Draft

Ros2cli diagnostics tool #328

wants to merge 26 commits into from

Conversation

russkel
Copy link

@russkel russkel commented Jan 21, 2024 •
edited

Adds a ros2 CLI tool:

TODO

  • rename to ros2diagnostics to follow convention
  • as per your suggestion change verbs to list/echo.
  • convert csv to an output format option on echo: ros2 diagnostics echo -f csv > my-csv.csv (unix philosophy)
    • add yaml/json output
  • refactor DiagnosticsParser into a generator with a WaitSet and remove mode
  • add self test verb
  • add tests

Replaces #301

robo and others added 26 commits October 7, 2023 11:11
@russkel
ros2diagnostics cli init
e7fff46
@russkel
rename hello to diagnostics
3391fee
@russkel
add option with string
6e12234 
csv --output
@russkel
arg parse examples
8a112d8
@russkel
add csv verb
1aed29a
@russkel
version 0.0.1
e2e917e
@robobe @ct2034 @russkel
Update ros2diagnostics_cli/package.xml
9a22aec 
Co-authored-by: Christian Henkel <6976069+ct2034@users.noreply.github.com>
@russkel
clean test and scripts file
f637fad
@russkel
add copyright
c13ce4e
@russkel
fix: support python 3.8 remove match
c4d5f29
@russkel
format and run linters
1c3ca74
@russkel
fix: suport python 3.8
e03df55 
remove math case
remove some of pylint warnings
@russkel
fix flake8 errors
6c2b60c
@russkel
fix: handle name without clone task name separator
f662b6c
@russkel
fix: extract node name
35aa3a4 
todo: add regex for extract node name from diagnostic name
@russkel
set version and license
85360cd
@russkel
init tutorials
6f1b85f
@russkel
remove diagnostic_tutorial from PR
afe944e
@ct2034 @russkel
gh tests for the new package
249b2db 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @russkel
fixing flake8 errors
3d43229 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@ct2034 @russkel
fixing pep257 errors
ccd80a2 
Signed-off-by: Christian Henkel <christian.henkel2@de.bosch.com>
@russkel
fix: address suggestions
8112093
@russkel
fix: remove _cli suffix
2dd80c0
@russkel
wip
38ab78b
@russkel
fix: list, show work
f9cb48c
@russkel
fix: rename show to echo
3935bf6
@russkel russkel marked this pull request as draft January 21, 2024 06:12
@ct2034 ct2034 added enhancement ros2 PR tackling a ROS2 branch needs more work labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement needs more work ros2 PR tackling a ROS2 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russkel @ct2034 @robobe