Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support masked array #263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

antoinecollet5
Copy link

Linked with issue #236

Add support for numpy masked array for measurement used in update methods and functions. This allow using masked array in batch_filter instead of list with None.

Unit tests have been updated and a working example can be found here:

Antoine COLLET added 2 commits December 27, 2021 16:08
…e methods and functions. This allox the use of masked array in batch_filter instead of list with None.
…te methods and functions. This allox the use of masked array in batch_filter instead of list with None.
@Jonny-air
Copy link

This would be a great feature!
I saw that the tests for None, and now for the masked array only include filter with measurement dimension 1. However currently the filter (only with None) fails if the dimension of z is larger than 1. I think with the mask check it should work (didn't get to test it yet), but in general I think this is something that should be in the tests.

@antoinecollet5
Copy link
Author

Hi @Jonny-air I'll have a look at it today ! Cheers :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants