Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need some help to reproduce pykalman behavior on simple linear example #262

Open
antoinecollet5 opened this issue Dec 16, 2021 · 2 comments

Comments

@antoinecollet5
Copy link

antoinecollet5 commented Dec 16, 2021

I want to switch from pykalman to filterpy because the later is not maintained anymore.

I try to reproduce a basic filtering and smoothing example that I did with pykalman (original code from Anton):

linear_case_pykalman.ipynb

However, I struggle to make it work with filterpy and I do not really get why... It has to do with missing values handing I guess.

linear_case_filterpy.ipynb

Thanks in advance for the help !

@Eheran1
Copy link

Eheran1 commented Apr 5, 2022

Page not found in both cases. Seems like they are here now. But where is the issue?

@antoinecollet5
Copy link
Author

antoinecollet5 commented Apr 5, 2022

Salut @Eheran1,

Thank you I fixed the two links.

Well, indeed, the second link relies on PR #263 which solves the issue. Here is the original notebook (using filterpy 1.4.5 from pypi). As you can see, the non handling of NaN causes problems and is not really compatible with a numpy approach.

Note that the PR has not been merged so the issue cannot be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants