Assignment not showing in Grade me block #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UNit test failure issue on v3.1.0.3
|
@jamesmcq Did you get a chance to review this? |
|
Has this been reviewed and tested? |
|
These changes have been pulled in, but I'm going to leave this open as it looks like the changes were just done manually, rather than pulling in your commit, meaning you didn't get the commit credit. Going to resolve this for next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Unit test failed because the condition asgn_sub.timemodified >= ag.timemodified were not met, so i have added one additional dataset in test_query_assign function to ensure the assertEquals pass.
Replaced the ag.grade = -1 by older condition ag.id IS NULL, as the system creates assign_grades entry in some scenarios with grade -1 and datemodifed, so in that case we don't probably need two condition on same OR statements, so checking ag.id is null would be perfect.